> -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@xilinx.com> > Sent: Wednesday, August 31, 2022 8:54 PM > To: Zhang, Qi Z <qi.z.zh...@intel.com>; Wang, Jie1X <jie1x.w...@intel.com>; > dev@dpdk.org > Cc: Yang, Qiming <qiming.y...@intel.com>; Wu, Jingjing > <jingjing...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; Yang, SteveX > <stevex.y...@intel.com> > Subject: Re: [PATCH v3 0/5] support flow subscription > > On 8/31/2022 1:28 PM, Zhang, Qi Z wrote: > > > > > >> -----Original Message----- > >> From: Ferruh Yigit <ferruh.yi...@xilinx.com> > >> Sent: Wednesday, August 31, 2022 6:57 PM > >> To: Wang, Jie1X <jie1x.w...@intel.com>; dev@dpdk.org > >> Cc: Yang, Qiming <qiming.y...@intel.com>; Zhang, Qi Z > >> <qi.z.zh...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Xing, > >> Beilei <beilei.x...@intel.com>; Yang, SteveX <stevex.y...@intel.com> > >> Subject: Re: [PATCH v3 0/5] support flow subscription > >> > >> On 8/30/2022 7:05 PM, Jie Wang wrote: > >>> Add support AVF can be able to subscribe a flow from PF. > >>> > >> > >> Hi Jie, > >> > >> Can you please provide more details, what does subscribing a flow > >> from PF mean? > > > > The answer is in patch 1/5's commit log which would be better in cover > > letter also :) > > > > Hi Qi, > > I checked all commit logs, but the feature wasn't clear to me, it can be > useful > to elaborate more. > > Is it the case that: > - PF create a flow rule > - VF subscribes to this rule, which means > - Packets will be sent to VF instead of PF
Correct. > > If above is correct, will both PF and VF receive packets, or only VF? Only VF will receive the packet. > Can multiple VF subscribe to same rule? Yes, it is allowed and the packet should be replicated, though we didn't see real use cases. > Can PF destroy the rule while VF is subscribed PF will destroy all subscription during VF reset. > How PF can prevent subscription to some flows from not trusted VF for > security concern? Good question, you almost let me go through the internal security review the second time. :) All subscription rule will have a lower priority than the rules that be created by host (e.g.: rules created by switchdev or DCF). I will suggest author to put all these information in the commit log. Thanks Qi > ... > > >> > >> Thanks, > >> ferruh > >> > >>> -- > >>> v3: > >>> * fix eth layer inputset. > >>> * rebase. > >>> v2: > >>> * split v1 patch 2/2 to 4 small patches. > >>> * remove rule action RTE_FLOW_ACTION_TYPE_VF and add > >>> RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT. > >>> > >>> Jie Wang (5): > >>> common/iavf: support flow subscription > >>> net/iavf: add flow subscription to AVF > >>> net/iavf: support flow subscrption pattern > >>> net/iavf: support flow subscription rule > >>> net/iavf: support priority of flow rule > >>> > >>> doc/guides/rel_notes/release_22_11.rst | 4 + > >>> drivers/common/iavf/virtchnl.h | 104 +++- > >>> drivers/net/iavf/iavf.h | 13 + > >>> drivers/net/iavf/iavf_fdir.c | 4 + > >>> drivers/net/iavf/iavf_fsub.c | 745 +++++++++++++++++++++++++ > >>> drivers/net/iavf/iavf_generic_flow.c | 40 +- > >>> drivers/net/iavf/iavf_generic_flow.h | 2 + > >>> drivers/net/iavf/iavf_hash.c | 5 + > >>> drivers/net/iavf/iavf_ipsec_crypto.c | 16 +- > >>> drivers/net/iavf/iavf_vchnl.c | 133 +++++ > >>> drivers/net/iavf/meson.build | 1 + > >>> 11 files changed, 1046 insertions(+), 21 deletions(-) > >>> create mode 100644 drivers/net/iavf/iavf_fsub.c > >>> > >
