<snip>
> >> > >> Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the same > >> by including the required header when RTE_LOG_DP_LEVEL is set to > >> RTE_LOG_DEBUG. > >> > >> ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’ > >> 678 | "%s: status: least acked token = %" PRIu64, > >> | ^~~~~~ > >> > >> Fixes: 30a1de105a5f ("lib: remove unneeded header includes") > >> Cc: sean.morris...@intel.com > > Agree on the fix. > > @sean.morris...@intel.com Does the process that removed this header file > inclusion needs fixing? > > If yes, should that fix be included in this patch? > > @honnappa.nagaraha...@arm.com Yes, I believe the tool will need an > update, however, I believe it should be a separate patch for that. Ok, as long as it is addressed, it should be fine. > > >> Signed-off-by: Anoob Joseph <ano...@marvell.com> > >> --- > >> lib/rcu/rte_rcu_qsbr.h | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index > >> d81bf5e8db..b0f1720ca1 100644 > >> --- a/lib/rcu/rte_rcu_qsbr.h > >> +++ b/lib/rcu/rte_rcu_qsbr.h > >> @@ -37,6 +37,10 @@ extern "C" { > >> #include <rte_atomic.h> > >> #include <rte_ring.h> > >> > >> +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #include <inttypes.h> #endif > >> + > >> extern int rte_rcu_log_type; > >> > >> #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG > >> -- > >> 2.25.1