> -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@xilinx.com> > Sent: Tuesday, August 16, 2022 17:33 > To: Guo, Junfeng <junfeng....@intel.com>; Singh, Aman Deep > <aman.deep.si...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; Wu, > Jingjing <jingjing...@intel.com>; Xing, Beilei <beilei.x...@intel.com> > Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.w...@intel.com>; Honnappa > Nagarahalli <honnappa.nagaraha...@arm.com> > Subject: Re: [PATCH v2] app/testpmd: add throughput stats for forward > streams > > On 8/11/2022 7:57 AM, Guo, Junfeng wrote: > > > > > >> -----Original Message----- > >> From: Singh, Aman Deep <aman.deep.si...@intel.com> > >> Sent: Friday, June 17, 2022 00:40 > >> To: Guo, Junfeng <junfeng....@intel.com>; Zhang, Qi Z > >> <qi.z.zh...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Xing, > >> Beilei <beilei.x...@intel.com> > >> Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.w...@intel.com> > >> Subject: Re: [PATCH v2] app/testpmd: add throughput stats for > >> forward streams > >> > >> Hi Junfeng, > >> > >> Thanks for the patch. > >> > >> > >> On 6/6/2022 3:09 PM, Junfeng Guo wrote: > >>> 1. add throughput statistics (in pps) for forward streams. > >>> 2. display the forward statistics for every forward stream. > >>> > >>> v2: > >>> add parameter descriptions and fix commit title. > >>> > >>> Signed-off-by: Xiao Wang <xiao.w.w...@intel.com> > >>> Signed-off-by: Junfeng Guo <junfeng....@intel.com> > >>> --- > >>> > >> We do have per port Rx/Tx pps in display stats. > >> For per forward stream we can enable "--record-burst-stats". > >> With it we can get per fwd stream Rx/Tx pps. > >> > >> Please check if this patch is adding any additional functionality. > > > > Sorry for the late reply. > > Seems that "--record-burst-stats" could only show the stats of Rx/Tx > bursts. > > > > Hi Junfeng, > > What is the impact of this change to the performance? > > And what do you think enabling it with an command, > like existing "set record-*" ones?
Thanks for your advice! We will consider about this method, and also the performance impact. Thanks a lot! Regards, Junfeng Guo > > > Actually this patch can enable the throughput stats, which has not been > supported in current testpmd. > > So we hope this functionality could be added. > > Thanks! > > > >> > >> <snip> > >
