Hi, V2 of the patch is submitted with suggested changes in __rte_timer_stop() function.
-Harish > -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: Wednesday, August 3, 2022 11:19 PM > To: Naga Harish K, S V <s.v.naga.haris...@intel.com> > Cc: Carrillo, Erik G <erik.g.carri...@intel.com>; dev@dpdk.org > Subject: Re: [PATCH 3/4] timer: fix rte_timer_stop_all > > On Wed, 3 Aug 2022 11:26:51 -0500 > Naga Harish K S V <s.v.naga.haris...@intel.com> wrote: > > > there is a possibility of deadlock in this api, as same spinlock is > > tried to be acquired in nested manner. > > > > This patch removes the acquisition of nested locking. > > > > Signed-off-by: Naga Harish K S V <s.v.naga.haris...@intel.com> > > The wording in this commit message is a little confusing, what is the exact > lock conflict? > > After your patch, there are no longer any callers for c with > the local_is_locked flag. Please resubmit and remove all the the > local_is_locked from __rte_timer_stop(). > > It looks like the test suite for rte_timer is not exercising all the exposed > API's. > That's a problem
