On Wed,  3 Aug 2022 11:26:51 -0500
Naga Harish K S V <s.v.naga.haris...@intel.com> wrote:

> there is a possibility of deadlock in this api,
> as same spinlock is tried to be acquired in nested manner.
> 
> This patch removes the acquisition of nested locking.
> 
> Signed-off-by: Naga Harish K S V <s.v.naga.haris...@intel.com>

The wording in this commit message is a little confusing, what is
the exact lock conflict? 

After your patch, there are no longer any callers for __rte_timer_stop()
with the local_is_locked flag. Please resubmit and remove all the
the local_is_locked from __rte_timer_stop().

It looks like the test suite for rte_timer is not exercising all
the exposed API's. That's a problem

Reply via email to