Hi Thomas, > -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Monday, August 1, 2022 6:01 PM > To: Wang, YuanX <yuanx.w...@intel.com> > Cc: andrew.rybche...@oktetlabs.ru; Li, Xiaoyun <xiaoyun...@intel.com>; > ferruh.yi...@xilinx.com; Singh, Aman Deep <aman.deep.si...@intel.com>; > dev@dpdk.org; Zhang, Yuying <yuying.zh...@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com>; jerinjac...@gmail.com; > step...@networkplumber.org; Wu, WenxuanX <wenxuanx...@intel.com>; > Ding, Xuan <xuan.d...@intel.com> > Subject: Re: [PATCH v9 1/4] ethdev: introduce protocol header API > > 01/08/2022 09:09, Wang, YuanX: > > Hi Thomas, > > > > Sorry so long to response your email. > > > > From: Thomas Monjalon <tho...@monjalon.net> > > > 13/06/2022 12:25, wenxuanx...@intel.com: > > > > From: Wenxuan Wu <wenxuanx...@intel.com> > > > > > > > > This patch added new ethdev API to retrieve supported protocol > > > > header mask of a PMD, which helps to configure protocol header based > buffer split. > > > > > > > > Signed-off-by: Wenxuan Wu <wenxuanx...@intel.com> > > > > --- > > > > +/** > > > > + * @warning > > > > + * @b EXPERIMENTAL: this API may change without prior notice > > > > + * > > > > + * Get supported header protocols to split supported by PMD. > > > > + * The API will return error if the device is not valid. > > > > + * > > > > + * @param port_id > > > > + * The port identifier of the device. > > > > + * @param ptype > > > > + * Supported protocol headers of driver. > > > > > > It doesn't say where to find the types. > > > Please give the prefix. > > > > Sorry I didn't catch your point, are you referring the ptype should be > composed of RTE_PTYPE_*? > > Could you explain it in more detail? > > Yes just give to the user the required info to use the function. > If ptype must be composed with RTE_PTYPE_*, it must be said.
Thanks for your explanation, will fix in the next version. Thanks, Yuan > > Thanks >
