Hi Thomas, Sorry so long to response your email.
> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Thursday, July 7, 2022 5:05 PM > To: Wu, WenxuanX <wenxuanx...@intel.com> > Cc: andrew.rybche...@oktetlabs.ru; Li, Xiaoyun <xiaoyun...@intel.com>; > ferruh.yi...@xilinx.com; Singh, Aman Deep <aman.deep.si...@intel.com>; > dev@dpdk.org; Zhang, Yuying <yuying.zh...@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com>; jerinjac...@gmail.com; > step...@networkplumber.org > Subject: Re: [PATCH v9 1/4] ethdev: introduce protocol header API > > 13/06/2022 12:25, wenxuanx...@intel.com: > > From: Wenxuan Wu <wenxuanx...@intel.com> > > > > This patch added new ethdev API to retrieve supported protocol header > > mask of a PMD, which helps to configure protocol header based buffer split. > > > > Signed-off-by: Wenxuan Wu <wenxuanx...@intel.com> > > --- > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Get supported header protocols to split supported by PMD. > > + * The API will return error if the device is not valid. > > + * > > + * @param port_id > > + * The port identifier of the device. > > + * @param ptype > > + * Supported protocol headers of driver. > > It doesn't say where to find the types. > Please give the prefix. Sorry I didn't catch your point, are you referring the ptype should be composed of RTE_PTYPE_*? Could you explain it in more detail? > > > + * @return > > + * - (-ENOTSUP) if header protocol is not supported by device. > > + * - (-ENODEV) if *port_id* invalid. > > + * - (-EIO) if device is removed. > > + * - (0) on success. > > + */ > > +__rte_experimental > > +int rte_eth_supported_hdrs_get(uint16_t port_id, > > + uint32_t *ptype); > > The function name is not precise enough. > There should be the word "split" in its name. Thanks for the suggestion, it will be revised in the next version. Thanks, Yuan >
