Don't do unnecessary casts when logging messages. Better to use
the correct printf format code.

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c 
b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
index 5f9a1cf..a585151 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
@@ -568,8 +568,8 @@ ixgbe_dev_queue_stats_mapping_set(struct rte_eth_dev 
*eth_dev,
                (hw->mac.type != ixgbe_mac_X550EM_x))
                return -ENOSYS;

-       PMD_INIT_LOG(INFO, "Setting port %d, %s queue_id %d to stat index %d",
-                    (int)(eth_dev->data->port_id), is_rx ? "RX" : "TX",
+       PMD_INIT_LOG(INFO, "Setting port %u, %s queue_id %d to stat index %d",
+                    eth_dev->data->port_id, is_rx ? "RX" : "TX",
                     queue_id, stat_idx);

        n = (uint8_t)(queue_id / NB_QMAP_FIELDS_PER_QSM_REG);
@@ -594,8 +594,8 @@ ixgbe_dev_queue_stats_mapping_set(struct rte_eth_dev 
*eth_dev,
        else
                stat_mappings->rqsmr[n] |= qsmr_mask;

-       PMD_INIT_LOG(INFO, "Set port %d, %s queue_id %d to stat index %d",
-                    (int)(eth_dev->data->port_id), is_rx ? "RX" : "TX",
+       PMD_INIT_LOG(INFO, "Set port %u, %s queue_id %d to stat index %d",
+                    eth_dev->data->port_id, is_rx ? "RX" : "TX",
                     queue_id, stat_idx);
        PMD_INIT_LOG(INFO, "%s[%d] = 0x%08x", is_rx ? "RQSMR" : "TQSM", n,
                     is_rx ? stat_mappings->rqsmr[n] : stat_mappings->tqsm[n]);
@@ -889,11 +889,11 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev)

        if (ixgbe_is_sfp(hw) && hw->phy.sfp_type != ixgbe_sfp_type_not_present)
                PMD_INIT_LOG(DEBUG, "MAC: %d, PHY: %d, SFP+: %d",
-                            (int) hw->mac.type, (int) hw->phy.type,
-                            (int) hw->phy.sfp_type);
+                            hw->mac.type, hw->phy.type,
+                            hw->phy.sfp_type);
        else
                PMD_INIT_LOG(DEBUG, "MAC: %d, PHY: %d",
-                            (int) hw->mac.type, (int) hw->phy.type);
+                            hw->mac.type, hw->phy.type);

        PMD_INIT_LOG(DEBUG, "port %d vendorID=0x%x deviceID=0x%x",
                        eth_dev->data->port_id, pci_dev->id.vendor_id,
@@ -2307,14 +2307,13 @@ ixgbe_dev_link_status_print(struct rte_eth_dev *dev)
        memset(&link, 0, sizeof(link));
        rte_ixgbe_dev_atomic_read_link_status(dev, &link);
        if (link.link_status) {
-               PMD_INIT_LOG(INFO, "Port %d: Link Up - speed %u Mbps - %s",
-                                       (int)(dev->data->port_id),
-                                       (unsigned)link.link_speed,
-                       link.link_duplex == ETH_LINK_FULL_DUPLEX ?
+               PMD_INIT_LOG(INFO, "Port %u: Link Up - speed %u Mbps - %s",
+                            dev->data->port_id, link.link_speed,
+                            link.link_duplex == ETH_LINK_FULL_DUPLEX ?
                                        "full-duplex" : "half-duplex");
        } else {
-               PMD_INIT_LOG(INFO, " Port %d: Link Down",
-                               (int)(dev->data->port_id));
+               PMD_INIT_LOG(INFO, "Port %u: Link Down",
+                               dev->data->port_id);
        }
        PMD_INIT_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
                                dev->pci_dev->addr.domain,
-- 
2.1.4

Reply via email to