21/06/2022 16:28, Morten Brørup:
> > From: David Marchand [mailto:david.march...@redhat.com]
> > Sent: Tuesday, 21 June 2022 16.13
> >
> > ALIGNMENT_MASK is only used internally.
> > Besides it lacks a DPDK-related prefix.
> > Hide it from external eyes.
> >
> > Reported-by: Morten Brørup <m...@smartsharesystems.com>
> > Signed-off-by: David Marchand <david.march...@redhat.com>
> > ---
> > --- a/lib/eal/x86/include/rte_memcpy.h
> > +++ b/lib/eal/x86/include/rte_memcpy.h
> > +#undef ALIGNMENT_MASK
>
> You could consider also giving another name with a lower risk of collision.
> However, I think the risk is very low, since it can only collide with other
> headers being included before this header file, so this suffices.
>
> Reviewed-by: Morten Brørup <m...@smartsharesystems.com>
Fixes: f5472703c0bd ("eal: optimize aligned memcpy on x86")
Cc: sta...@dpdk.org
Applied, thanks.
