On 6/15/2022 3:56 PM, Kalesh A P wrote:


From: Damodharam Ammepalli <damodharam.ammep...@broadcom.com>

Currently, we fail the init/probe of pmd if eth_dev->data->nb_tx_queues
or eth_dev->data->nb_rx_queues is 0. We are removing this check.


Is there a valid usecase for Rx only or Tx only config?
I assume testpmd doesn't support it, how are you testing this?

Fixes: daef48efe5e5 ("net/bnxt: support set MTU")
Cc: sta...@dpdk.org

Signed-off-by: Damodharam Ammepalli <damodharam.ammep...@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.ko...@broadcom.com>
---
  drivers/net/bnxt/bnxt_ethdev.c | 7 +------
  1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 34f2149..8181e1f 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -723,7 +723,7 @@ static int bnxt_alloc_prev_ring_stats(struct bnxt *bp)
                                              sizeof(struct bnxt_ring_stats) *
                                              bp->tx_cp_nr_rings,
                                              0);
-       if (bp->prev_tx_ring_stats == NULL)
+       if (bp->tx_cp_nr_rings > 0 && bp->prev_tx_ring_stats == NULL)
                 goto error;

         return 0;
@@ -1567,11 +1567,6 @@ int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
         int vlan_mask = 0;
         int rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT;

-       if (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) {
-               PMD_DRV_LOG(ERR, "Queues are not configured yet!\n");
-               return -EINVAL;
-       }
-
         if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS)
                 PMD_DRV_LOG(ERR,
                             "RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n",
--
2.10.1


Reply via email to