On Thu, Jun 9, 2022 at 2:17 PM Stanislaw Kardach <k...@semihalf.com> wrote: > > As David noticed in [1] there is an issue with C++ compilation of the > rte_vect.h header in RISC-V. Upon closer inspection, the problem appears on > all architectures due to the type conversion rules in C++. > More precisely a union type rte_xmm_t requires a conversion constructor > from xmm_t type. > The most obvious fix is to use a structure initializer for such copies > (since rte_xmm_t union contains xmm_t anyway). The generated assembly > at -O2 is exactly the same, so there's no real impact. > > The bigger question is whether accessing bits of the architecture specific > xmm_t type in an array fashion is always correct? All current architectures > define rte_xmm_t in the same manner implying that.
Copying other arch maintainers. > > Additionally change RISC-V CI settings to use crossbuild-essential-riscv64 > package which provides tools that enable C++ checks. > > [1] http://mails.dpdk.org/archives/dev/2022-June/243683.html > > Stanislaw Kardach (3): > eal/riscv: fix xmm_t casting for C++ > lpm: fix xmm_t casting for C++ in scalar version > ci: use crossbuild-essential-riscv64 for compiling In any case, this series looks good. Series applied, thanks Stanislaw. -- David Marchand
