On Mon, Jun 13, 2022 at 12:08 PM Pavan Nikhilesh Bhagavatula
<pbhagavat...@marvell.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Shijith Thotton <sthot...@marvell.com>
> > Sent: Thursday, June 2, 2022 5:15 PM
> > To: Jerin Jacob Kollanukkaran <jer...@marvell.com>
> > Cc: Shijith Thotton <sthot...@marvell.com>; dev@dpdk.org; Pavan
> > Nikhilesh Bhagavatula <pbhagavat...@marvell.com>
> > Subject: [PATCH] app/test-eventdev: wait for workers before cryptodev
> > destroy
> >
> > Destroying cryptodev resources before exiting workers are not safe.
> > Moved cryptodev destroy after worker thread exit in main thread.
> >
> > Fixes: de2bc16e1bd1 ("app/eventdev: add crypto producer mode")Cc: sta...@dpdk.org > > > > Signed-off-by: Shijith Thotton <sthot...@marvell.com> > > Acked-by: Pavan Nikhilesh <pbhagavat...@marvell.com> Acked-by: Jerin Jacob <jer...@marvell.com> Applied to dpdk-next-net-eventdev/for-main. Thanks > > > --- > > app/test-eventdev/evt_main.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/app/test-eventdev/evt_main.c b/app/test-eventdev/evt_main.c > > index c5d63061bf..b785e603ee 100644 > > --- a/app/test-eventdev/evt_main.c > > +++ b/app/test-eventdev/evt_main.c > > @@ -159,9 +159,6 @@ main(int argc, char **argv) > > if (test->ops.ethdev_rx_stop) > > test->ops.ethdev_rx_stop(test, &opt); > > > > - if (test->ops.cryptodev_destroy) > > - test->ops.cryptodev_destroy(test, &opt); > > - > > rte_eal_mp_wait_lcore(); > > > > if (test->ops.test_result) > > @@ -173,6 +170,9 @@ main(int argc, char **argv) > > if (test->ops.eventdev_destroy) > > test->ops.eventdev_destroy(test, &opt); > > > > + if (test->ops.cryptodev_destroy) > > + test->ops.cryptodev_destroy(test, &opt); > > + > > if (test->ops.mempool_destroy) > > test->ops.mempool_destroy(test, &opt); > > > > -- > > 2.25.1 >
