RE: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark

[Spike Du]

> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Monday, May 23, 2022 6:59 PM
> To: Spike Du <spi...@nvidia.com>; Morten Brørup
> <m...@smartsharesystems.com>
> Cc: Matan Azrad <ma...@nvidia.com>; Slava Ovsiienko
> <viachesl...@nvidia.com>; Ori Kam <or...@nvidia.com>; dev@dpdk.org;
> Raslan Darawsheh <rasl...@nvidia.com>
> Subject: Re: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark
> 
> External email: Use caution opening links or attachments
> 
> 
> 23/05/2022 08:07, Morten Brørup:
> > > +   uint8_t lwm;
> >
> > Why percentage, why not 1/128th, or 1/16th? 2^N seems more logical, and
> I wonder if such high granularity is really necessary. Just a thought, it's 
> not
> important.
> 
> I think percentage is the easiest to understand and to share with other teams
> in design documents.
> 
> > If you stick with percentage, it only needs 7 bits, and you can make the
> remaining one bit reserved.

Agree, will change to use 7 bits.
> >
> > Also, please add here that 0 means disable.

Sure.
> 
> Good idea.
>