On 5/18/22 22:46, David Marchand wrote:
Introduce a testpmd API so that drivers can register specific commands.

A driver can list some files to compile with testpmd, by setting them
in the testpmd_sources (driver local) meson variable.
drivers/meson.build then takes care of appending this to a global meson
variable, and adding the driver to testpmd dependency.

Note: testpmd.h is fixed to that it is self sufficient when being
included.

Signed-off-by: David Marchand <david.march...@redhat.com>

LGTM, just one nit below.

Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>

[snip]

@@ -94,6 +97,7 @@ static void cmd_help_brief_parsed(__rte_unused void 
*parsed_result,
                "    help filters                    : Filters configuration 
help.\n"
                "    help traffic_management         : Traffic Management 
commands.\n"
                "    help devices                    : Device related cmds.\n"
+               "    help drivers                    : Driver specific cmds.\n"

I'd not mimic the previous line here and use full "commands"
instead as two lines above.

                "    help all                        : All of the above 
sections.\n\n"
        );

[snip]

Reply via email to