Hello,

Following TB decision [1] and recent discussions on the driver specific
commands in testpmd, here is a proposal on how the split could be done.

For now, this series simply moves the testpmd code in the driver
directory. The driver specific testpmd code is still compiled as part of
testpmd compilation via a global meson testpmd_driver_sources list.

Notes:
- ixgbe bypass commands in testpmd were "dead" code since switch to meson,
  as the RTE_LIBRTE_IXGBE_BYPASS define is not set while compiling testpmd.
  No one complained about issue for the last two years, so those commands
  are dropped.


1: https://mails.dpdk.org/archives/dev/2022-April/239191.html

-- 
David Marchand

Changes since RFC v2:
- extended cleanup patch 1,
- fixed command registration (again..),
- dropped ixgbe bypass commands,
- fixed some indent,
- updated documentation,

Changes since RFC v1:
- added a cleanup as patch 1, to make all parser symbols static,
- fixed registering issue in patch 1,
- moved more i40e specific commands, fixed checkpatch warnings,

David Marchand (6):
  app/testpmd: mark most cmdline symbols as static
  app/testpmd: register driver specific commands
  net/bonding: move testpmd commands
  net/i40e: move testpmd commands
  app/testpmd: drop ixgbe bypass commands
  net/ixgbe: move testpmd commands

 app/test-pmd/bpf_cmd.c                        |    20 +-
 app/test-pmd/cmdline.c                        | 15404 ++++++----------
 app/test-pmd/cmdline_flow.c                   |     8 +-
 app/test-pmd/cmdline_mtr.c                    |   219 +-
 app/test-pmd/cmdline_tm.c                     |   442 +-
 app/test-pmd/config.c                         |    43 -
 app/test-pmd/meson.build                      |     8 +-
 app/test-pmd/testpmd.c                        |    18 +-
 app/test-pmd/testpmd.h                        |    30 +-
 doc/guides/nics/i40e.rst                      |   184 +-
 doc/guides/nics/ixgbe.rst                     |    51 +
 .../link_bonding_poll_mode_drv_lib.rst        |   143 +
 doc/guides/testpmd_app_ug/testpmd_funcs.rst   |   433 +-
 drivers/meson.build                           |     5 +
 drivers/net/bonding/bonding_testpmd.c         |  1029 ++
 drivers/net/bonding/meson.build               |     1 +
 drivers/net/i40e/i40e_testpmd.c               |  2634 +++
 drivers/net/i40e/meson.build                  |     2 +
 drivers/net/ixgbe/ixgbe_testpmd.c             |   657 +
 drivers/net/ixgbe/meson.build                 |     2 +
 meson.build                                   |     2 +
 21 files changed, 10437 insertions(+), 10898 deletions(-)
 create mode 100644 drivers/net/bonding/bonding_testpmd.c
 create mode 100644 drivers/net/i40e/i40e_testpmd.c
 create mode 100644 drivers/net/ixgbe/ixgbe_testpmd.c

-- 
2.36.1

Reply via email to