RE: [EXT] [PATCH v4 4/8] examples/fips_validation: allow json file as input

[Gowrishankar Muthukrishnan]

+lylav...@iol.unh.edu

> -----Original Message-----
> From: Gowrishankar Muthukrishnan
> Sent: Thursday, May 19, 2022 11:00 AM
> To: Brandon Lo <b...@iol.unh.edu>; roy.fan.zh...@intel.com;
> ciara.po...@intel.com
> Cc: dev@dpdk.org
> Subject: RE: [EXT] [PATCH v4 4/8] examples/fips_validation: allow json file as
> input
> 
> Please find comments inline from CI point of view.
> 
> > -----Original Message-----
> ....
> ....
> >  main(int argc, char *argv[])
> >  {
> >     int ret;
> > +   char use_json;
> >
> >     ret = rte_eal_init(argc, argv);
> >     if (ret < 0) {
> > @@ -424,9 +436,17 @@ main(int argc, char *argv[])
> >                                     ret, env.req_path);
> >                     goto exit;
> >             }
> > -
> > -
> > +           use_json = info.file_type == FIPS_TYPE_JSON;
> 
> use_json is not required apart from setting info.file_type. Some CI build 
> fails
> for unused use_json (when !RTE_HAS_JANSSON). Can this be removed ?.
> 
> Thanks,
> Gowrishankar