14/04/2022 07:52, Christian Ehrhardt: > On Wed, Apr 13, 2022 at 12:06 PM Kevin Traynor <ktray...@redhat.com> wrote: > > commit 026470bafaa02cba0d46ed7b7e835262399a009a > > Author: Thomas Monjalon <tho...@monjalon.net> > > Date: Sun Mar 6 10:20:23 2022 +0100 > > > > build: hide local symbols in shared libraries > > > > [ upstream commit b403498e14229ee903c8fff9baefcb72894062f3 ] > > > > In this case the symbol is not redesignated but removed, but it doesn't > > look to have any use to a user, so I think it can be safe to remove. > > I'm 100% with all others, thanks for having a look. > On this one I can easily follow the argument of the fix for the newest > release. > But for stable we can never really know if there are users. > In theory for anything that shipped in a Distribution someone might > have coded and linked something against it - we would not know. > The meant to be "stable" update will then break them the hard way. > > In this case gladly the function wasn't anything that one would > consider useful for use from outside, so I think it is ok. > > But still I wanted to make the point that in general a symbol: > 1. once released might be used and we can not never be sure if no one uses > them > 2. even being EXPERIMENTAL, touching them too much in stable updates > means not-stable. Should we at least try to minimize the impact to > stable releases?
Hiding symbols is mostly to enable future changes. I'm not sure there is a need for such patch in a stable release.
