Hi Abhinandan and others, > + @Jayatheerthan, Jay & @Vangati, Narender > > > This change would be an ABI breakage. So to avoid that, we are planning to > > Propose a better solution compared to this patch. > > We plan to add a new cryptodev op to set the event metadata. A single API > > which can be used in all cases - sym/asym/security sessions. > > > > As currently in case of sym crypto, userdata is being used for storing the > > event > > Metadata and it is then dereferenced in the PMD which is wrong. > > User data is meant only for user to use and PMD should not dereference it. > > > > Hence a new cryptodev op can be used to set session event metadata > > explicitly > > if event mode is enabled. > > > > I will be sending the proposal soon. Would need your help in testing the > > Intel > > usecases. > >
We may need to stick to the approach introduced in this patch only. As if we propose, a new single API for all type of sessions, the driver would need to Get the event metadata from the session private data. This is not possible with Your use case which gets it inside the eventdev library for sw adapter case as it cannot Get the session private data without knowing the cdev_id. Hence, we will take this patch as is in next release for security sessions(as it is an ABI break) And would also introduce a similar change for crypto sessions in next release. This way we can get rid of using userdata which is wrong implementation. Regards, Akhil
