On 03/09/2015 08:18 PM, Stephen Hemminger wrote:
> The ixgbe driver likes to be far to chatty in the system log
> which is good for the original developer but not good for a production
> product.
>
> Reduce the log spam by doing:
> * All the normal messages should be changed from INFO to DEBUG.
> * The log messages should be done with RTE_LOG so that they can be
> compiled out if RTE_LOG_LEVEL is set.
> * The link state print routine prints more than is necessary
> PCI information is already known (earlier in log) and has
> no purpose here.
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
This patch is broken.
The changes are there twice.
I removed the first part of the mail.
> ---
> lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 15 +++++----------
> lib/librte_pmd_ixgbe/ixgbe_logs.h | 3 +--
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 12 ++++++------
> 3 files changed, 12 insertions(+), 18 deletions(-)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> index 9bdc046..171809f 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> @@ -2293,20 +2293,15 @@ ixgbe_dev_link_status_print(struct rte_eth_dev *dev)
> memset(&link, 0, sizeof(link));
> rte_ixgbe_dev_atomic_read_link_status(dev, &link);
> if (link.link_status) {
> - PMD_INIT_LOG(INFO, "Port %d: Link Up - speed %u Mbps - %s",
> - (int)(dev->data->port_id),
> + PMD_INIT_LOG(DEBUG, "Port %u: Link Up - speed %u Mbps - %s",
> + dev->data->port_id,
> (unsigned)link.link_speed,
> link.link_duplex == ETH_LINK_FULL_DUPLEX ?
> "full-duplex" : "half-duplex");
> } else {
> - PMD_INIT_LOG(INFO, " Port %d: Link Down",
> - (int)(dev->data->port_id));
> - }
> - PMD_INIT_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
> - dev->pci_dev->addr.domain,
> - dev->pci_dev->addr.bus,
> - dev->pci_dev->addr.devid,
> - dev->pci_dev->addr.function);
> + PMD_INIT_LOG(DEBUG, "Port %d: Link Down",
> + dev->data->port_id);
> + }
> }
Well, I would say that PMD_INIT_LOG should not be called from here.
PMD_DRV_LOG should be the preferred macro (pure debug stuff, out of init).
The rest looks fine to me.
--
David Marchand
