> From: Akhil Goyal <akhil.go...@nxp.com>
> 
> This patch supports AES_GMAC algorithm for DPAA2
> driver.
> 
> Signed-off-by: Akhil Goyal <akhil.go...@nxp.com>
> Signed-off-by: Gagandeep Singh <g.si...@nxp.com>
> ---
>  doc/guides/cryptodevs/features/dpaa2_sec.ini |  1 +
>  drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c  | 14 ++++++++-
>  drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h    | 30 ++++++++++++++++++++
>  lib/cryptodev/rte_crypto_sym.h               |  4 ++-
>  4 files changed, 47 insertions(+), 2 deletions(-)

This patch should be split in two - cryptodev change should be separate patch.

> diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/rte_crypto_sym.h
> index daa090b978..4644fa3e25 100644
> --- a/lib/cryptodev/rte_crypto_sym.h
> +++ b/lib/cryptodev/rte_crypto_sym.h
> @@ -467,8 +467,10 @@ enum rte_crypto_aead_algorithm {
>       /**< AES algorithm in CCM mode. */
>       RTE_CRYPTO_AEAD_AES_GCM,
>       /**< AES algorithm in GCM mode. */
> -     RTE_CRYPTO_AEAD_CHACHA20_POLY1305
> +     RTE_CRYPTO_AEAD_CHACHA20_POLY1305,
>       /**< Chacha20 cipher with poly1305 authenticator */
> +     RTE_CRYPTO_AEAD_AES_GMAC
> +     /**< AES algorithm in GMAC mode. */
>  };
AES-GMAC is also defined as AUTH algo. It may be removed but that would be
ABI break.
Is it not possible to use AES-GMAC as auth algo?

Reply via email to