>-----Original Message----- >From: Neil Horman [mailto:nhorman at tuxdriver.com] >Sent: Friday, March 13, 2015 2:59 PM >To: Kavanagh, Mark B >Cc: dev at dpdk.org >Subject: Re: [dpdk-dev] [PATCH v3] ABI: Add abi checking utility > >On Fri, Mar 13, 2015 at 02:25:17PM +0000, Kavanagh, Mark B wrote: >> >On Fri, Mar 13, 2015 at 11:56:59AM +0000, Kavanagh, Mark B wrote: >> >> >> >> >> >> >-----Original Message----- >> >> >From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman >> >> >Sent: Wednesday, March 4, 2015 4:27 PM >> >> >To: dev at dpdk.org >> >> >Subject: [dpdk-dev] [PATCH v3] ABI: Add abi checking utility >> >> > >> >> >> (snip) >> >> >> >+log "INFO" "Building DPDK $TAG1. This might take a moment" >> >> >+make O=$TARGET > $VERBOSE 2>&1 >> >> >+ >> >> >+if [ $? -ne 0 ] >> >> >+then >> >> >+ log "INFO" "THE BUILD FAILED. ABORTING" >> >> >> >> If the build fails while TAG1 is checked out, the user must check out >> >> their original >> >local branch manually. I'd prefer it if the script checked out >> >$CURRENT_BRANCH in the >> >'cleanup_and_exit' function. >> >> >> >Sure, its in V4. >> >> Cool. >> >> > >> >> Same applies to TAG2, if the user CTRL-C's out of the script, and to any >> >> other >command >> >that might fail when a particular branch/tag is checked out (for example, >> >the 'sed' >> >commands fail when I run the script; however, they work when I run them on >> >the command >> >line - I'm investigating this currently). >> >> >> >What does the log say? Please post it here. If it helps add a set -x to >> >the >> >top of the script for additional verbosity. >> > >> >> Hey Neil - this is the error, but it's not a problem with the script; >> presumably I'd >cleaned my DPDK installation directory, so 'sed' couldn't find the defconfig >file: >> "sed: can't read config/defconfig_x86_64-ivshmem-linuxapp-gcc/: Not a >> directory" >> >Actually, it looks to me like you added a trailing "/" to the end of the third >argument on the script command line, so sed bombs when it tries to modify a >directory instead of a file. Try specifying: >x86_64-ivshmem-linuxapp-gcc >instead of >x86_64-ivshmem-linuxapp-gcc/ > >Neil
Nice catch - thanks! > >> Thanks, >> Mark >> >> >Neil >> >>
