> -----Original Message----- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Thursday, March 12, 2015 10:18 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; Richardson, Bruce; Tetsuya Mukawa > Subject: [PATCH v2 02/15] eal: Close file descriptor of uio configuration > > When pci_uio_unmap_resource() is called, a file descriptor that is used for > uio configuration should be > closed. > > Signed-off-by: Tetsuya Mukawa <mukawa at igel.co.jp> > --- > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c > b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c > index 6f229d6..77bb5ed 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c > @@ -462,6 +462,8 @@ pci_uio_unmap_resource(struct rte_pci_device *dev) > > /* close fd if in primary process */ > close(dev->intr_handle.fd); > + if (dev->intr_handle.uio_cfg_fd >= 0) > + close(dev->intr_handle.uio_cfg_fd); Hi Tetsuya,
Should dev->intr_handle.uio_cfg_fd be set to -1 after closing it? Regards, Bernard. > > dev->intr_handle.fd = -1; > dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN; > -- > 1.9.1
