On 2015/03/09 11:23, Tetsuya Mukawa wrote: > On 2015/03/06 19:32, Iremonger, Bernard wrote: > >> Hi Tetsuya, >> >> The above functions being added to /lib/librte_eal/bsdapp/eal/eal_pci.c are >> very similar to the functions >> in lib/librte_eal/linuxapp/eal/eal_pci.c the main difference seems to be >> "struct uio_resource *uio_res" in bsd >> and "struct mapped_pci_resource *uio_res " in linux. >> Both of these structures are the same although named differently. >> There are at present only 3 references to "struct uio_resource" in >> librte_eal/bsdapp/eal/eal_pci.c. If "struct uio_resource" was renamed to" >> struct mapped_pci_resource " the functions being added to >> bsdapp/eal/eal_pci.c would be the same as the functions in >> linuxapp/eal/eal_pci.c. >> If both groups of functions were the same it would make sense to have only >> one copy of these functions which could be moved into >> librte_eal/common/eal_common_pci.c . >> >> There may be some extra work in doing this but I think it would make the >> code more maintainable in the future. >> What do you think? > Hi Bernard, > > Yes, I agree with it. > I will merge above, and submit again. > Thanks for suggestion. > > Regards, > Tetsuya >
Hi Bernard, I've sent v2 patches. The patches depends on the latest master branch. So if you apply it, could you please pull first? Also, I tried to separate patches for reviewer, but if you feel it should be squashed more, please let me know. Thanks, Tetsuya
