RE: [PATCH v2 14/16] net/pfe: disable HW CRC stripping

[Nipun Gupta]

> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: 27 December 2021 23:19
> To: Nipun Gupta <nipun.gu...@nxp.com>
> Cc: dev@dpdk.org; tho...@monjalon.net; ferruh.yi...@intel.com; Hemant
> Agrawal <hemant.agra...@nxp.com>; Gagandeep Singh <g.si...@nxp.com>
> Subject: Re: [PATCH v2 14/16] net/pfe: disable HW CRC stripping
> 
> On Mon, 27 Dec 2021 21:46:43 +0530
> nipun.gu...@nxp.com wrote:
> 
> > @@ -422,8 +422,11 @@ pfe_eth_close(struct rte_eth_dev *dev)
> >  }
> >
> >  static int
> > -pfe_eth_configure(struct rte_eth_dev *dev __rte_unused)
> > +pfe_eth_configure(struct rte_eth_dev *dev)
> >  {
> > +   if (dev->data->dev_conf.rxmode.offloads &
> DEV_RX_OFFLOAD_KEEP_CRC)
> > +           PFE_PMD_ERR("PMD does not support KEEP_CRC offload");
> > +
> >     return 0;
> >  }
> >
> 
> Why is this necessary? There is already a check for offload capabilities in
> rte_eth_dev_configure(). The device should report correct supported offloads
> instead.

Agree. Will remove this patch.