Hi Ramkumar,
> -----Original Message-----
> From: Ramkumar Balu <rb...@marvell.com>
> Sent: Monday, November 29, 2021 10:52 AM
> To: Akhil Goyal <gak...@marvell.com>; Anoob Joseph <ano...@marvell.com>;
> Doherty, Declan <declan.dohe...@intel.com>; Zhang, Roy Fan
> <roy.fan.zh...@intel.com>; Ankur Dwivedi <adwiv...@marvell.com>; Tejasree
> Kondoj <ktejas...@marvell.com>
> Cc: sta...@dpdk.org; dev@dpdk.org; Ramkumar <rb...@marvell.com>
> Subject: [PATCH 0/5] cryptodev: fix inconsistency in RSA op usage
>
> From: Ramkumar <rb...@marvell.com>
>
> The RSA verify operation is performed in two stages: 1. decrypt using public
> key
> (output: plaintext message) 2. Compare resultant plaintext message with the
> expected plaintext message to verify. (return succ/fail in status field) Some
> applications need the decrypted plaintext (stage 1 result) also to be
> retunred.
[Arek] - It should only be the case when NO_PADDING selected (that's why QAT
returns decrypted data, and only because of that), but I would propose to
change it that NO_PADDING signature is not possible -> change it to NO_PADDING
Private/Public operations (we cannot verify it in PMD anyway as we do not know
padding type).
> For reference, OpenSSL also provides similar API (RSA_public_decrypt).
[Arek] - this function is not only deprecated but incorrect. It should not be
used for signatures when padding selected. Normally functions that handle
padding will only return verification status only, not data.
>
> lib cryptodev API failed to specify a field in 'struct
> rte_crypto_rsa_op_param' to
> return the plaintext result after public key decryption. It created
> inconsistency
> among crypto PMDs in returning plaintext during RSA verify.
>
> Inconsistency in RSA verify,
> crypto/octeontx - uses 'sign' field to return plaintext crypto/cnxk - uses
> 'sign'
> field to return plaintext crypto/openssl - does not return plaintext
> crypto/qat -
> uses 'cipher' field to return plaintext test/cryptodev_asym - expects PMDs to
> use
> 'cipher' field
>
> Thus, this patch series fixes all usages to only use 'cipher' field for above
> described scenario. The 'sign' and 'message' fields are not chosen as they
> are
> used for different purpose under same operation.
>
> rte_crypto_rsa_op_param struct fields to use for
> RTE_CRYPTO_ASYM_OP_VERIFY:
> 1. input: rsa.sign - signature to be decrypted or verified 2. input:
> rsa.message -
> expected plaintext, used to compare 3. output: rsa.cipher - resultant
> plaintext
> from decryption
>
>
> Ramkumar (5):
> cryptodev: fix RSA op cipher field description
> crypto/openssl: fix output of RSA verify op
> crypto/octeontx: fix output field for RSA verify
> crypto/octeontx2: fix output field for RSA verify
> crypto/cnxk: fix output field for RSA verify
>
> drivers/crypto/cnxk/cnxk_ae.h | 15 +++++++++------
> drivers/crypto/octeontx/otx_cryptodev_ops.c | 10 ++++++----
> drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 16 +++++++++-------
> drivers/crypto/openssl/rte_openssl_pmd.c | 16 +++++++++++-----
> lib/cryptodev/rte_crypto_asym.h | 7 ++++---
> 5 files changed, 39 insertions(+), 25 deletions(-)
>
> --
> 2.17.1
