From: Ramkumar <rb...@marvell.com>

During RSA verify, the OpenSSL PMD fails to return the plaintext after
public key decryption.
This patch fixes the OpenSSL PMD to return the decrypted plaintext in
cipher.data / cipher.length fields

Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations")
Fixes: fe1606e0138c ("crypto/openssl: fix RSA verify operation")
Cc: sta...@dpdk.org

Signed-off-by: Ramkumar <rb...@marvell.com>
---
 drivers/crypto/openssl/rte_openssl_pmd.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c 
b/drivers/crypto/openssl/rte_openssl_pmd.c
index 5794ed8159..3ab2c3b5c1 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -1953,12 +1953,16 @@ process_openssl_rsa_op(struct rte_crypto_op *cop,
                break;
 
        case RTE_CRYPTO_ASYM_OP_VERIFY:
-               tmp = rte_malloc(NULL, op->rsa.sign.length, 0);
+               tmp = op->rsa.cipher.data;
                if (tmp == NULL) {
-                       OPENSSL_LOG(ERR, "Memory allocation failed");
-                       cop->status = RTE_CRYPTO_OP_STATUS_ERROR;
-                       break;
+                       tmp = rte_malloc(NULL, op->rsa.sign.length, 0);
+                       if (tmp == NULL) {
+                               OPENSSL_LOG(ERR, "Memory allocation failed");
+                               cop->status = RTE_CRYPTO_OP_STATUS_ERROR;
+                               break;
+                       }
                }
+
                ret = RSA_public_decrypt(op->rsa.sign.length,
                                op->rsa.sign.data,
                                tmp,
@@ -1974,7 +1978,9 @@ process_openssl_rsa_op(struct rte_crypto_op *cop,
                        OPENSSL_LOG(ERR, "RSA sign Verification failed");
                        cop->status = RTE_CRYPTO_OP_STATUS_ERROR;
                }
-               rte_free(tmp);
+               op->rsa.cipher.length = ret;
+               if (tmp != op->rsa.cipher.data)
+                       rte_free(tmp);
                break;
 
        default:
-- 
2.17.1

Reply via email to