On 11/29/2021 2:12 PM, Josh Soref wrote:
On Mon, Nov 29, 2021, 9:05 AM Ferruh Yigit <ferruh.yi...@intel.com
<mailto:ferruh.yi...@intel.com>> wrote:
On 11/29/2021 1:59 PM, Bruce Richardson wrote:
> On Mon, Nov 29, 2021 at 12:49:56PM +0000, Ferruh Yigit wrote:
>> Hi Josh, Thanks for the patch.
>>
>> The typo fixes for comments and logs are more straightforward, but I
have
>> mixed feeling about the variable / macro typo fixes, let's see what
others
>> think.
>>
>> And I think we should get this patch either one of the first patch or
last
>> patch to prevent conflict with other patches.
>
> +1 to being a first patch to start things off clean.
>
> For the macros, since there is quick a bit of content in the patch, could
> we have the patch split into a separate patch for macro changes to review
> separately, allowing the simple doc/printf spelling changes to go in
> immediately?
Yeah, this is doable. I'll see if I can do it now. It's a lot of files, plus
I'll need to figure out the command sequence to reply to this thread. If
someone is available on Slack for some handholding, that might help me get it
done faster.
Also as far as I can see there are multiple build errors related to the
variable / macro renames, which was the concern.
I'm used to having access to GitHub based CI that let me test before making a
PR. I've locally dropped the peer change, but didn't resubmit since I figured
I'd wait for replies.
(Last night I installed meson and ninja, so I might be able to do a local
build.)
Following changes fixes the build errors, I am not saying they are the
best fix, that is just to give you an idea what is failing:
diff --git a/drivers/baseband/acc100/acc100_pf_enum.h
b/drivers/baseband/acc100/acc100_pf_enum.h
index a1ee416d26c1..cdb58dfbb92e 100644
--- a/drivers/baseband/acc100/acc100_pf_enum.h
+++ b/drivers/baseband/acc100/acc100_pf_enum.h
@@ -42,11 +42,11 @@ enum {
HWPfQmgrDebugProcessWdTimeoutMsiFifo = 0x00A001C4,
HWPfQmgrDepthLog2Grp = 0x00A00200,
HWPfQmgrTholdGrp = 0x00A00300,
- HWPfQmgrGrpTmplateReg0Indx = 0x00A00600,
- HWPfQmgrGrpTmplateReg1Indx = 0x00A00680,
- HWPfQmgrGrpTmplateReg2indx = 0x00A00700,
- HWPfQmgrGrpTmplateReg3Indx = 0x00A00780,
- HWPfQmgrGrpTmplateReg4Indx = 0x00A00800,
+ HWPfQmgrGrpTemplateReg0Indx = 0x00A00600,
+ HWPfQmgrGrpTemplateReg1Indx = 0x00A00680,
+ HWPfQmgrGrpTemplateReg2indx = 0x00A00700,
+ HWPfQmgrGrpTemplateReg3Indx = 0x00A00780,
+ HWPfQmgrGrpTemplateReg4Indx = 0x00A00800,
HWPfQmgrVfBaseAddr = 0x00A01000,
HWPfQmgrUl4GWeightRrVf = 0x00A02000,
HWPfQmgrDl4GWeightRrVf = 0x00A02100,
@@ -113,7 +113,7 @@ enum {
HWPfDmaStatusDataErrLoVf = 0x00B8085C,
HWPfDmaStatusDataErrHiVf = 0x00B80860,
HWPfDmaCfgMsiEnSoftwareErr = 0x00B80864,
- HWPfDmaDescriptorSignatuture = 0x00B80868,
+ HWPfDmaDescriptorSignature = 0x00B80868,
HWPfDmaFcwSignature = 0x00B8086C,
HWPfDmaErrorDetectionEn = 0x00B80870,
HWPfDmaErrCntrlFifoDebug = 0x00B8087C,
diff --git a/drivers/common/cnxk/hw/nix.h b/drivers/common/cnxk/hw/nix.h
index dd2ebecc6a9c..ee8cb91d92a8 100644
--- a/drivers/common/cnxk/hw/nix.h
+++ b/drivers/common/cnxk/hw/nix.h
@@ -921,7 +921,7 @@ struct nix_band_prof_s {
uint64_t icolor : 2;
uint64_t tnl_ena : 1;
uint64_t rsvd_7_5 : 3;
- uint64_t peir_exponent : 5;
+ uint64_t peer_exponent : 5;
uint64_t rsvd_15_13 : 3;
uint64_t pebs_exponent : 5;
uint64_t rsvd_23_21 : 3;
@@ -929,7 +929,7 @@ struct nix_band_prof_s {
uint64_t rsvd_31_29 : 3;
uint64_t cbs_exponent : 5;
uint64_t rsvd_39_37 : 3;
- uint64_t peir_mantissa : 8;
+ uint64_t peer_mantissa : 8;
uint64_t pebs_mantissa : 8;
uint64_t cir_mantissa : 8;
uint64_t cbs_mantissa : 8;
diff --git a/drivers/crypto/qat/qat_sym_session.h
b/drivers/crypto/qat/qat_sym_session.h
index 21afb90cad3a..6965b31efc53 100644
--- a/drivers/crypto/qat/qat_sym_session.h
+++ b/drivers/crypto/qat/qat_sym_session.h
@@ -141,10 +141,6 @@ qat_sym_session_clear(struct rte_cryptodev *dev,
unsigned int
qat_sym_session_get_private_size(struct rte_cryptodev *dev);
-void
-qat_sym_session_init_common_hdr(struct qat_sym_session *session,
- struct icp_qat_fw_comn_req_hdr *header,
- enum qat_sym_proto_flag proto_flags);
int
qat_sym_validate_aes_key(int key_len, enum icp_qat_hw_cipher_algo *alg);
int
diff --git a/drivers/crypto/virtio/virtio_cryptodev.c
b/drivers/crypto/virtio/virtio_cryptodev.c
index ce23e38b791f..80db2fe21e74 100644
--- a/drivers/crypto/virtio/virtio_cryptodev.c
+++ b/drivers/crypto/virtio/virtio_cryptodev.c
@@ -862,7 +862,7 @@ virtio_crypto_dev_free_mbufs(struct rte_cryptodev *dev)
VIRTIO_CRYPTO_INIT_LOG_DBG("queue_pairs[%d]=%p",
i, dev->data->queue_pairs[i]);
- virtqueue_detach_unused(dev->data->queue_pairs[i]);
+ virtqueue_detatch_unused(dev->data->queue_pairs[i]);
VIRTIO_CRYPTO_INIT_LOG_DBG("After freeing dataq[%d] used and "
"unused buf", i);
diff --git a/drivers/crypto/virtio/virtqueue.c
b/drivers/crypto/virtio/virtqueue.c
index 33985d1dab96..fd8be581c996 100644
--- a/drivers/crypto/virtio/virtqueue.c
+++ b/drivers/crypto/virtio/virtqueue.c
@@ -22,7 +22,7 @@ virtqueue_disable_intr(struct virtqueue *vq)
}
void
-virtqueue_detach_unused(struct virtqueue *vq)
+virtqueue_detatch_unused(struct virtqueue *vq)
{
struct rte_crypto_op *cop = NULL;
diff --git a/drivers/crypto/virtio/virtqueue.h b/drivers/crypto/virtio/virtqueue.h
index 1a67b408403a..c96ca629921b 100644
--- a/drivers/crypto/virtio/virtqueue.h
+++ b/drivers/crypto/virtio/virtqueue.h
@@ -99,7 +99,7 @@ void virtqueue_disable_intr(struct virtqueue *vq);
/**
* Get all mbufs to be freed.
*/
-void virtqueue_detach_unused(struct virtqueue *vq);
+void virtqueue_detatch_unused(struct virtqueue *vq);
static inline int
virtqueue_full(const struct virtqueue *vq)
diff --git a/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c
b/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c
index 27f42d8cb23b..b09cccedf587 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c
+++ b/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c
@@ -102,9 +102,9 @@ int32_t bnxt_rss_config_action_apply(struct
bnxt_ulp_mapper_parms *parms)
#define ULP_FILE_PATH_SIZE 256
-static int32_t glob_error_fn(const char *epath, int32_t errno)
+static int32_t glob_error_fn(const char *epath, int32_t eerrno)
{
- BNXT_TF_DBG(ERR, "path %s error %d\n", epath, errno);
+ BNXT_TF_DBG(ERR, "path %s error %d\n", epath, eerrno);
return 0;
}
diff --git a/drivers/regex/mlx5/mlx5_regex_fastpath.c b/drivers/regex/mlx5/mlx5_regex_fastpath.c
index 72464cad64ea..9a2db7e43fd0 100644
--- a/drivers/regex/mlx5/mlx5_regex_fastpath.c
+++ b/drivers/regex/mlx5/mlx5_regex_fastpath.c
@@ -226,7 +226,7 @@ complete_umr_wqe(struct mlx5_regex_qp *qp, struct
mlx5_regex_hw_qp *qp_obj,
rte_cpu_to_be_32(mkey_job->imkey->id));
/* Set UMR WQE control seg. */
ucseg->mkey_mask |= rte_cpu_to_be_64(MLX5_WQE_UMR_CTRL_MKEY_MASK_LEN |
- MLX5_WQE_UMR_CTRL_FLAG_TRANSLATION_OFFSET |
+ MLX5_WQE_UMR_CTRL_FLAG_TRNSLATION_OFFSET |
MLX5_WQE_UMR_CTRL_MKEY_MASK_ACCESS_LOCAL_WRITE);
ucseg->klm_octowords = rte_cpu_to_be_16(klm_align);
/* Set mkey context seg. */
