On Mon, Nov 29, 2021 at 09:12:53AM -0500, Josh Soref wrote: > On Mon, Nov 29, 2021, 9:05 AM Ferruh Yigit <[1]ferruh.yi...@intel.com> > wrote: > > On 11/29/2021 1:59 PM, Bruce Richardson wrote: > > On Mon, Nov 29, 2021 at 12:49:56PM +0000, Ferruh Yigit wrote: > >> Hi Josh, Thanks for the patch. > >> > >> The typo fixes for comments and logs are more straightforward, > but I have > >> mixed feeling about the variable / macro typo fixes, let's see > what others > >> think. > >> > >> And I think we should get this patch either one of the first > patch or last > >> patch to prevent conflict with other patches. > > > > +1 to being a first patch to start things off clean. > > > > For the macros, since there is quick a bit of content in the > patch, could > > we have the patch split into a separate patch for macro changes to > review > > separately, allowing the simple doc/printf spelling changes to go > in > > immediately? > > Yeah, this is doable. I'll see if I can do it now. It's a lot of files, > plus I'll need to figure out the command sequence to reply to this > thread. If someone is available on Slack for some handholding, that > might help me get it done faster.
Thanks. To reply to this thread with any new patches add "--in-reply-to 20211126195851.50167-1-jso...@users.noreply.github.com" to your git send-email command. (The long string above is the message id from the email headers of your original patch. you can get it from patchwork if you look at the headers or also the address to your patch in patchwork [1]). [1] http://patches.dpdk.org/project/dpdk/patch/20211126195851.50167-1-jso...@users.noreply.github.com/
