On Fri, Nov 5, 2021 at 4:57 PM Jim Harris <james.r.har...@intel.com> wrote: > > clang-13 rightfully complains that the tot_ppi > variable in update_stats is set but not used, since > the final accumulated tot_ppi results isn't used > anywhere. > > Original idea was to just remove the tot_ppi variable, > but feedback from David Marchand on mailing list was > that the related ppi_av array in struct priority_worker > wasn't useful and should be removed. This allows us > to also remove num_dequeue_pkts_prev and pc from > struct priority_worker since they are only used in > conjunction with the ppi_av array.
This library has its internals exposed to the world for no good reason. I am pretty sure all those structures could be hidden in the .c. It is still an experimental API: we can hope it gets cleaned up at some point. This patch that drops dead code is a first step and lgtm. > > Signed-off-by: Jim Harris <james.r.har...@intel.com> Reviewed-by: David Marchand <david.march...@redhat.com> -- David Marchand
