2015-03-09 09:08, Vlad Zolotarov: > > On 03/08/15 23:12, Thomas Monjalon wrote: > > Hi Vlad, > > > > 2015-03-08 16:04, Vlad Zolotarov: > >> According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should > >> be configured to the same value as HLREG0.RXCRCSTRP. > >> > >> Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec > >> but seems harmless. > >> > >> Signed-off-by: Vlad Zolotarov <vladz at cloudius-systems.com> > > You are mixing a fix (this patch) and enhancements (LRO) in the same series. > > Could you separate them please, as LRO is not going into 2.0 but this fix > > is a good candidate. > > Pls, note that all patches in this series except for PATCH3 and PATCH5 > are fixing real bugs. I can send them as a separate series if u'd like. > Pls., confirm.
Yes you're right, patch 1 is also a fix and patch 4 seems to solve other issues. However, patch 4 makes also some refactoring and seems a bit risky. We need an ixgbe maintainer to decide wether we can merge it before the release. Or is it possible to have fixes of the patch 4 without the refactoring? Thanks Vlad. Sorry to request such split but this PMD is sensible and I don't want to have a risk of making it worst in release 2.0.
