This patch add-in specific asymmetric crypto session and build
op request implementation for QAT generations

Signed-off-by: Kai Ji <kai...@intel.com>
---
 drivers/common/qat/qat_qp.c                  |   5 +-
 drivers/crypto/qat/dev/qat_asym_pmd_gen1.c   |   7 +
 drivers/crypto/qat/dev/qat_crypto_pmd_gens.h |   3 +
 drivers/crypto/qat/qat_asym.c                | 620 ++++++++++---------
 drivers/crypto/qat/qat_asym.h                |  65 +-
 5 files changed, 389 insertions(+), 311 deletions(-)

diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c
index a026b90ca7..a3db053c82 100644
--- a/drivers/common/qat/qat_qp.c
+++ b/drivers/common/qat/qat_qp.c
@@ -622,7 +622,7 @@ qat_enqueue_op_burst(void *qp,
 #ifdef BUILD_QAT_ASYM
                        ret = qat_asym_build_request(*ops, base_addr + tail,
                                tmp_qp->op_cookies[tail >> queue->trailz],
-                               tmp_qp->qat_dev_gen);
+                               NULL, tmp_qp->qat_dev_gen);
 #endif
                }
                if (ret != 0) {
@@ -850,7 +850,8 @@ qat_dequeue_op_burst(void *qp, void **ops,
 #ifdef BUILD_QAT_ASYM
                else if (tmp_qp->service_type == QAT_SERVICE_ASYMMETRIC)
                        qat_asym_process_response(ops, resp_msg,
-                               tmp_qp->op_cookies[head >> rx_queue->trailz]);
+                               tmp_qp->op_cookies[head >> rx_queue->trailz],
+                               NULL);
 #endif
 
                head = adf_modulo(head + rx_queue->msg_size,
diff --git a/drivers/crypto/qat/dev/qat_asym_pmd_gen1.c 
b/drivers/crypto/qat/dev/qat_asym_pmd_gen1.c
index 9ed1f21d9d..99d90fa56c 100644
--- a/drivers/crypto/qat/dev/qat_asym_pmd_gen1.c
+++ b/drivers/crypto/qat/dev/qat_asym_pmd_gen1.c
@@ -65,6 +65,13 @@ qat_asym_crypto_feature_flags_get_gen1(
        return feature_flags;
 }
 
+int
+qat_asym_crypto_set_session_gen1(void *cdev __rte_unused,
+               void *session __rte_unused)
+{
+       return 0;
+}
+
 RTE_INIT(qat_asym_crypto_gen1_init)
 {
        qat_asym_gen_dev_ops[QAT_GEN1].cryptodev_ops =
diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h 
b/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h
index 783fdcaa34..6277211b35 100644
--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h
+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h
@@ -853,6 +853,9 @@ qat_sym_session_set_ext_hash_flags_gen2(struct 
qat_sym_session *session,
 struct qat_capabilities_info
 qat_asym_crypto_cap_get_gen1(struct qat_pci_device *qat_dev);
 
+int
+qat_asym_crypto_set_session_gen1(void *cryptodev, void *session);
+
 uint64_t
 qat_asym_crypto_feature_flags_get_gen1(struct qat_pci_device *qat_dev);
 
diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c
index f893508030..e2a5fb9260 100644
--- a/drivers/crypto/qat/qat_asym.c
+++ b/drivers/crypto/qat/qat_asym.c
@@ -1,69 +1,115 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2019 Intel Corporation
+ * Copyright(c) 2019 - 2021 Intel Corporation
  */
 
 #include <stdarg.h>
 
-#include "qat_asym.h"
+#include <cryptodev_pmd.h>
+
 #include "icp_qat_fw_pke.h"
 #include "icp_qat_fw.h"
 #include "qat_pke_functionality_arrays.h"
 
-#define qat_asym_sz_2param(arg) (arg, sizeof(arg)/sizeof(*arg))
+#include "qat_device.h"
 
-static int qat_asym_get_sz_and_func_id(const uint32_t arr[][2],
-               size_t arr_sz, size_t *size, uint32_t *func_id)
+#include "qat_logs.h"
+#include "qat_asym.h"
+
+int
+qat_asym_session_configure(struct rte_cryptodev *dev,
+               struct rte_crypto_asym_xform *xform,
+               struct rte_cryptodev_asym_session *sess,
+               struct rte_mempool *mempool)
 {
-       size_t i;
+       int err = 0;
+       void *sess_private_data;
+       struct qat_asym_session *session;
 
-       for (i = 0; i < arr_sz; i++) {
-               if (*size <= arr[i][0]) {
-                       *size = arr[i][0];
-                       *func_id = arr[i][1];
-                       return 0;
+       if (rte_mempool_get(mempool, &sess_private_data)) {
+               QAT_LOG(ERR,
+                       "Couldn't get object from session mempool");
+               return -ENOMEM;
+       }
+
+       session = sess_private_data;
+       if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_MODEX) {
+               if (xform->modex.exponent.length == 0 ||
+                               xform->modex.modulus.length == 0) {
+                       QAT_LOG(ERR, "Invalid mod exp input parameter");
+                       err = -EINVAL;
+                       goto error;
+               }
+       } else if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_MODINV) {
+               if (xform->modinv.modulus.length == 0) {
+                       QAT_LOG(ERR, "Invalid mod inv input parameter");
+                       err = -EINVAL;
+                       goto error;
                }
+       } else if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_RSA) {
+               if (xform->rsa.n.length == 0) {
+                       QAT_LOG(ERR, "Invalid rsa input parameter");
+                       err = -EINVAL;
+                       goto error;
+               }
+       } else if (xform->xform_type >= RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END
+                       || xform->xform_type <= RTE_CRYPTO_ASYM_XFORM_NONE) {
+               QAT_LOG(ERR, "Invalid asymmetric crypto xform");
+               err = -EINVAL;
+               goto error;
+       } else {
+               QAT_LOG(ERR, "Asymmetric crypto xform not implemented");
+               err = -EINVAL;
+               goto error;
        }
-       return -1;
-}
 
-static inline void qat_fill_req_tmpl(struct icp_qat_fw_pke_request *qat_req)
-{
-       memset(qat_req, 0, sizeof(*qat_req));
-       qat_req->pke_hdr.service_type = ICP_QAT_FW_COMN_REQ_CPM_FW_PKE;
+       session->xform = xform;
+       qat_asym_build_req_tmpl(sess_private_data);
+       set_asym_session_private_data(sess, dev->driver_id,
+               sess_private_data);
 
-       qat_req->pke_hdr.hdr_flags =
-                       ICP_QAT_FW_COMN_HDR_FLAGS_BUILD
-                       (ICP_QAT_FW_COMN_REQ_FLAG_SET);
+       return 0;
+error:
+       rte_mempool_put(mempool, sess_private_data);
+       return err;
 }
 
-static inline void qat_asym_build_req_tmpl(void *sess_private_data)
+unsigned int
+qat_asym_session_get_private_size(
+               struct rte_cryptodev *dev __rte_unused)
 {
-       struct icp_qat_fw_pke_request *qat_req;
-       struct qat_asym_session *session = sess_private_data;
-
-       qat_req = &session->req_tmpl;
-       qat_fill_req_tmpl(qat_req);
+       return RTE_ALIGN_CEIL(sizeof(struct qat_asym_session), 8);
 }
 
-static size_t max_of(int n, ...)
+void
+qat_asym_session_clear(struct rte_cryptodev *dev,
+               struct rte_cryptodev_asym_session *sess)
 {
-       va_list args;
-       size_t len = 0, num;
-       int i;
+       uint8_t index = dev->driver_id;
+       void *sess_priv = get_asym_session_private_data(sess, index);
+       struct qat_asym_session *s = (struct qat_asym_session *)sess_priv;
 
-       va_start(args, n);
-       len = va_arg(args, size_t);
+       if (sess_priv) {
+               memset(s, 0, qat_asym_session_get_private_size(dev));
+               struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv);
 
-       for (i = 0; i < n - 1; i++) {
-               num = va_arg(args, size_t);
-               if (num > len)
-                       len = num;
+               set_asym_session_private_data(sess, index, NULL);
+               rte_mempool_put(sess_mp, sess_priv);
        }
-       va_end(args);
-
-       return len;
 }
 
+/* An rte_driver is needed in the registration of both the device and the 
driver
+ * with cryptodev.
+ * The actual qat pci's rte_driver can't be used as its name represents
+ * the whole pci device with all services. Think of this as a holder for a name
+ * for the crypto part of the pci device.
+ */
+static const char qat_asym_drv_name[] = RTE_STR(CRYPTODEV_NAME_QAT_ASYM_PMD);
+static const struct rte_driver cryptodev_qat_asym_driver = {
+       .name = qat_asym_drv_name,
+       .alias = qat_asym_drv_name
+};
+
+
 static void qat_clear_arrays(struct qat_asym_op_cookie *cookie,
                int in_count, int out_count, int alg_size)
 {
@@ -106,7 +152,230 @@ static void qat_clear_arrays_by_alg(struct 
qat_asym_op_cookie *cookie,
        }
 }
 
-static int qat_asym_check_nonzero(rte_crypto_param n)
+static void qat_asym_collect_response(struct rte_crypto_op *rx_op,
+               struct qat_asym_op_cookie *cookie,
+               struct rte_crypto_asym_xform *xform)
+{
+       size_t alg_size, alg_size_in_bytes = 0;
+       struct rte_crypto_asym_op *asym_op = rx_op->asym;
+
+       if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_MODEX) {
+               rte_crypto_param n = xform->modex.modulus;
+
+               alg_size = cookie->alg_size;
+               alg_size_in_bytes = alg_size >> 3;
+               uint8_t *modexp_result = asym_op->modex.result.data;
+
+               if (rx_op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED) {
+                       rte_memcpy(modexp_result +
+                               (asym_op->modex.result.length -
+                                       n.length),
+                               cookie->output_array[0] + alg_size_in_bytes
+                               - n.length, n.length
+                               );
+                       rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+                       QAT_DP_HEXDUMP_LOG(DEBUG, "ModExp result",
+                                       cookie->output_array[0],
+                                       alg_size_in_bytes);
+
+#endif
+               }
+       } else if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_MODINV) {
+               rte_crypto_param n = xform->modinv.modulus;
+
+               alg_size = cookie->alg_size;
+               alg_size_in_bytes = alg_size >> 3;
+               uint8_t *modinv_result = asym_op->modinv.result.data;
+
+               if (rx_op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED) {
+                       rte_memcpy(modinv_result +
+                               (asym_op->modinv.result.length
+                               - n.length),
+                               cookie->output_array[0] + alg_size_in_bytes
+                               - n.length, n.length);
+                       rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+                       QAT_DP_HEXDUMP_LOG(DEBUG, "ModInv result",
+                                       cookie->output_array[0],
+                                       alg_size_in_bytes);
+#endif
+               }
+       } else if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_RSA) {
+
+               alg_size = cookie->alg_size;
+               alg_size_in_bytes = alg_size >> 3;
+               if (asym_op->rsa.op_type == RTE_CRYPTO_ASYM_OP_ENCRYPT ||
+                               asym_op->rsa.op_type ==
+                                       RTE_CRYPTO_ASYM_OP_VERIFY) {
+                       if (asym_op->rsa.op_type ==
+                                       RTE_CRYPTO_ASYM_OP_ENCRYPT) {
+                               uint8_t *rsa_result = asym_op->rsa.cipher.data;
+
+                               rte_memcpy(rsa_result,
+                                               cookie->output_array[0],
+                                               alg_size_in_bytes);
+                               rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+                               QAT_DP_HEXDUMP_LOG(DEBUG, "RSA Encrypted data",
+                                               cookie->output_array[0],
+                                               alg_size_in_bytes);
+#endif
+                       } else if (asym_op->rsa.op_type ==
+                                       RTE_CRYPTO_ASYM_OP_VERIFY) {
+                               uint8_t *rsa_result = asym_op->rsa.cipher.data;
+
+                               switch (asym_op->rsa.pad) {
+                               case RTE_CRYPTO_RSA_PADDING_NONE:
+                                       rte_memcpy(rsa_result,
+                                                       cookie->output_array[0],
+                                                       alg_size_in_bytes);
+                                       rx_op->status =
+                                               RTE_CRYPTO_OP_STATUS_SUCCESS;
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+                               QAT_DP_HEXDUMP_LOG(DEBUG, "RSA Signature",
+                                               cookie->output_array[0],
+                                               alg_size_in_bytes);
+#endif
+                                       break;
+                               default:
+                                       QAT_LOG(ERR, "Padding not supported");
+                                       rx_op->status =
+                                               RTE_CRYPTO_OP_STATUS_ERROR;
+                                       break;
+                               }
+                       }
+               } else {
+                       if (asym_op->rsa.op_type ==
+                                       RTE_CRYPTO_ASYM_OP_DECRYPT) {
+                               uint8_t *rsa_result = asym_op->rsa.message.data;
+
+                               switch (asym_op->rsa.pad) {
+                               case RTE_CRYPTO_RSA_PADDING_NONE:
+                                       rte_memcpy(rsa_result,
+                                               cookie->output_array[0],
+                                               alg_size_in_bytes);
+                                       rx_op->status =
+                                               RTE_CRYPTO_OP_STATUS_SUCCESS;
+                                       break;
+                               default:
+                                       QAT_LOG(ERR, "Padding not supported");
+                                       rx_op->status =
+                                               RTE_CRYPTO_OP_STATUS_ERROR;
+                                       break;
+                               }
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+                               QAT_DP_HEXDUMP_LOG(DEBUG, "RSA Decrypted 
Message",
+                                               rsa_result, alg_size_in_bytes);
+#endif
+                       } else if (asym_op->rsa.op_type ==
+                                       RTE_CRYPTO_ASYM_OP_SIGN) {
+                               uint8_t *rsa_result = asym_op->rsa.sign.data;
+
+                               rte_memcpy(rsa_result,
+                                               cookie->output_array[0],
+                                               alg_size_in_bytes);
+                               rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+                               QAT_DP_HEXDUMP_LOG(DEBUG, "RSA Signature",
+                                               cookie->output_array[0],
+                                               alg_size_in_bytes);
+#endif
+                       }
+               }
+       }
+       qat_clear_arrays_by_alg(cookie, xform, alg_size_in_bytes);
+}
+
+int
+qat_asym_process_response(void __rte_unused * *op, uint8_t *resp,
+               void *op_cookie, __rte_unused uint64_t *dequeue_err_count)
+{
+       struct qat_asym_session *ctx;
+       struct icp_qat_fw_pke_resp *resp_msg =
+                       (struct icp_qat_fw_pke_resp *)resp;
+       struct rte_crypto_op *rx_op = (struct rte_crypto_op *)(uintptr_t)
+                       (resp_msg->opaque);
+       struct qat_asym_op_cookie *cookie = op_cookie;
+
+       if (cookie->error) {
+               cookie->error = 0;
+               if (rx_op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED)
+                       rx_op->status = RTE_CRYPTO_OP_STATUS_ERROR;
+               QAT_DP_LOG(ERR, "Cookie status returned error");
+       } else {
+               if (ICP_QAT_FW_PKE_RESP_PKE_STAT_GET(
+                       resp_msg->pke_resp_hdr.resp_status.pke_resp_flags)) {
+                       if (rx_op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED)
+                               rx_op->status = RTE_CRYPTO_OP_STATUS_ERROR;
+                       QAT_DP_LOG(ERR, "Asymmetric response status"
+                                       " returned error");
+               }
+               if (resp_msg->pke_resp_hdr.resp_status.comn_err_code) {
+                       if (rx_op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED)
+                               rx_op->status = RTE_CRYPTO_OP_STATUS_ERROR;
+                       QAT_DP_LOG(ERR, "Asymmetric common status"
+                                       " returned error");
+               }
+       }
+
+       if (rx_op->sess_type == RTE_CRYPTO_OP_WITH_SESSION) {
+               ctx = (struct qat_asym_session *)get_asym_session_private_data(
+                       rx_op->asym->session, qat_asym_driver_id);
+               qat_asym_collect_response(rx_op, cookie, ctx->xform);
+       } else if (rx_op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
+               qat_asym_collect_response(rx_op, cookie, rx_op->asym->xform);
+       }
+       *op = rx_op;
+
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+       QAT_DP_HEXDUMP_LOG(DEBUG, "resp_msg:", resp_msg,
+                       sizeof(struct icp_qat_fw_pke_resp));
+#endif
+
+       return 1;
+}
+
+#define qat_asym_sz_2param(arg) (arg, sizeof(arg)/sizeof(*arg))
+
+static int
+qat_asym_get_sz_and_func_id(const uint32_t arr[][2],
+               size_t arr_sz, size_t *size, uint32_t *func_id)
+{
+       size_t i;
+
+       for (i = 0; i < arr_sz; i++) {
+               if (*size <= arr[i][0]) {
+                       *size = arr[i][0];
+                       *func_id = arr[i][1];
+                       return 0;
+               }
+       }
+       return -1;
+}
+
+static size_t
+max_of(int n, ...)
+{
+       va_list args;
+       size_t len = 0, num;
+       int i;
+
+       va_start(args, n);
+       len = va_arg(args, size_t);
+
+       for (i = 0; i < n - 1; i++) {
+               num = va_arg(args, size_t);
+               if (num > len)
+                       len = num;
+       }
+       va_end(args);
+
+       return len;
+}
+
+static int
+qat_asym_check_nonzero(rte_crypto_param n)
 {
        if (n.length < 8) {
                /* Not a case for any cryptograpic function except for DH
@@ -475,10 +744,9 @@ qat_asym_fill_arrays(struct rte_crypto_asym_op *asym_op,
 }
 
 int
-qat_asym_build_request(void *in_op,
-                       uint8_t *out_msg,
-                       void *op_cookie,
-                       __rte_unused enum qat_device_gen qat_dev_gen)
+qat_asym_build_request(void *in_op, uint8_t *out_msg, void *op_cookie,
+               __rte_unused uint64_t *opaque,
+               __rte_unused enum qat_device_gen dev_gen)
 {
        struct qat_asym_session *ctx;
        struct rte_crypto_op *op = (struct rte_crypto_op *)in_op;
@@ -545,263 +813,7 @@ qat_asym_build_request(void *in_op,
        return 0;
 }
 
-static void qat_asym_collect_response(struct rte_crypto_op *rx_op,
-               struct qat_asym_op_cookie *cookie,
-               struct rte_crypto_asym_xform *xform)
-{
-       size_t alg_size, alg_size_in_bytes = 0;
-       struct rte_crypto_asym_op *asym_op = rx_op->asym;
-
-       if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_MODEX) {
-               rte_crypto_param n = xform->modex.modulus;
-
-               alg_size = cookie->alg_size;
-               alg_size_in_bytes = alg_size >> 3;
-               uint8_t *modexp_result = asym_op->modex.result.data;
-
-               if (rx_op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED) {
-                       rte_memcpy(modexp_result +
-                               (asym_op->modex.result.length -
-                                       n.length),
-                               cookie->output_array[0] + alg_size_in_bytes
-                               - n.length, n.length
-                               );
-                       rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
-                       QAT_DP_HEXDUMP_LOG(DEBUG, "ModExp result",
-                                       cookie->output_array[0],
-                                       alg_size_in_bytes);
-
-#endif
-               }
-       } else if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_MODINV) {
-               rte_crypto_param n = xform->modinv.modulus;
-
-               alg_size = cookie->alg_size;
-               alg_size_in_bytes = alg_size >> 3;
-               uint8_t *modinv_result = asym_op->modinv.result.data;
-
-               if (rx_op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED) {
-                       rte_memcpy(modinv_result + 
(asym_op->modinv.result.length
-                               - n.length),
-                               cookie->output_array[0] + alg_size_in_bytes
-                               - n.length, n.length);
-                       rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
-                       QAT_DP_HEXDUMP_LOG(DEBUG, "ModInv result",
-                                       cookie->output_array[0],
-                                       alg_size_in_bytes);
-#endif
-               }
-       } else if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_RSA) {
-
-               alg_size = cookie->alg_size;
-               alg_size_in_bytes = alg_size >> 3;
-               if (asym_op->rsa.op_type == RTE_CRYPTO_ASYM_OP_ENCRYPT ||
-                               asym_op->rsa.op_type ==
-                                       RTE_CRYPTO_ASYM_OP_VERIFY) {
-                       if (asym_op->rsa.op_type ==
-                                       RTE_CRYPTO_ASYM_OP_ENCRYPT) {
-                               uint8_t *rsa_result = asym_op->rsa.cipher.data;
-
-                               rte_memcpy(rsa_result,
-                                               cookie->output_array[0],
-                                               alg_size_in_bytes);
-                               rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
-                               QAT_DP_HEXDUMP_LOG(DEBUG, "RSA Encrypted data",
-                                               cookie->output_array[0],
-                                               alg_size_in_bytes);
-#endif
-                       } else if (asym_op->rsa.op_type ==
-                                       RTE_CRYPTO_ASYM_OP_VERIFY) {
-                               uint8_t *rsa_result = asym_op->rsa.cipher.data;
-
-                               switch (asym_op->rsa.pad) {
-                               case RTE_CRYPTO_RSA_PADDING_NONE:
-                                       rte_memcpy(rsa_result,
-                                                       cookie->output_array[0],
-                                                       alg_size_in_bytes);
-                                       rx_op->status =
-                                               RTE_CRYPTO_OP_STATUS_SUCCESS;
-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
-                               QAT_DP_HEXDUMP_LOG(DEBUG, "RSA Signature",
-                                               cookie->output_array[0],
-                                               alg_size_in_bytes);
-#endif
-                                       break;
-                               default:
-                                       QAT_LOG(ERR, "Padding not supported");
-                                       rx_op->status =
-                                               RTE_CRYPTO_OP_STATUS_ERROR;
-                                       break;
-                               }
-                       }
-               } else {
-                       if (asym_op->rsa.op_type ==
-                                       RTE_CRYPTO_ASYM_OP_DECRYPT) {
-                               uint8_t *rsa_result = asym_op->rsa.message.data;
-
-                               switch (asym_op->rsa.pad) {
-                               case RTE_CRYPTO_RSA_PADDING_NONE:
-                                       rte_memcpy(rsa_result,
-                                               cookie->output_array[0],
-                                               alg_size_in_bytes);
-                                       rx_op->status =
-                                               RTE_CRYPTO_OP_STATUS_SUCCESS;
-                                       break;
-                               default:
-                                       QAT_LOG(ERR, "Padding not supported");
-                                       rx_op->status =
-                                               RTE_CRYPTO_OP_STATUS_ERROR;
-                                       break;
-                               }
-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
-                               QAT_DP_HEXDUMP_LOG(DEBUG, "RSA Decrypted 
Message",
-                                               rsa_result, alg_size_in_bytes);
-#endif
-                       } else if (asym_op->rsa.op_type == 
RTE_CRYPTO_ASYM_OP_SIGN) {
-                               uint8_t *rsa_result = asym_op->rsa.sign.data;
-
-                               rte_memcpy(rsa_result,
-                                               cookie->output_array[0],
-                                               alg_size_in_bytes);
-                               rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
-                               QAT_DP_HEXDUMP_LOG(DEBUG, "RSA Signature",
-                                               cookie->output_array[0],
-                                               alg_size_in_bytes);
-#endif
-                       }
-               }
-       }
-       qat_clear_arrays_by_alg(cookie, xform, alg_size_in_bytes);
-}
-
-void
-qat_asym_process_response(void **op, uint8_t *resp,
-               void *op_cookie)
-{
-       struct qat_asym_session *ctx;
-       struct icp_qat_fw_pke_resp *resp_msg =
-                       (struct icp_qat_fw_pke_resp *)resp;
-       struct rte_crypto_op *rx_op = (struct rte_crypto_op *)(uintptr_t)
-                       (resp_msg->opaque);
-       struct qat_asym_op_cookie *cookie = op_cookie;
-
-       if (cookie->error) {
-               cookie->error = 0;
-               if (rx_op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED)
-                       rx_op->status = RTE_CRYPTO_OP_STATUS_ERROR;
-               QAT_DP_LOG(ERR, "Cookie status returned error");
-       } else {
-               if (ICP_QAT_FW_PKE_RESP_PKE_STAT_GET(
-                       resp_msg->pke_resp_hdr.resp_status.pke_resp_flags)) {
-                       if (rx_op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED)
-                               rx_op->status = RTE_CRYPTO_OP_STATUS_ERROR;
-                       QAT_DP_LOG(ERR, "Asymmetric response status"
-                                       " returned error");
-               }
-               if (resp_msg->pke_resp_hdr.resp_status.comn_err_code) {
-                       if (rx_op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED)
-                               rx_op->status = RTE_CRYPTO_OP_STATUS_ERROR;
-                       QAT_DP_LOG(ERR, "Asymmetric common status"
-                                       " returned error");
-               }
-       }
-
-       if (rx_op->sess_type == RTE_CRYPTO_OP_WITH_SESSION) {
-               ctx = (struct qat_asym_session *)get_asym_session_private_data(
-                       rx_op->asym->session, qat_asym_driver_id);
-               qat_asym_collect_response(rx_op, cookie, ctx->xform);
-       } else if (rx_op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
-               qat_asym_collect_response(rx_op, cookie, rx_op->asym->xform);
-       }
-       *op = rx_op;
-
-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
-       QAT_DP_HEXDUMP_LOG(DEBUG, "resp_msg:", resp_msg,
-                       sizeof(struct icp_qat_fw_pke_resp));
-#endif
-}
-
-int
-qat_asym_session_configure(struct rte_cryptodev *dev,
-               struct rte_crypto_asym_xform *xform,
-               struct rte_cryptodev_asym_session *sess,
-               struct rte_mempool *mempool)
-{
-       int err = 0;
-       void *sess_private_data;
-       struct qat_asym_session *session;
-
-       if (rte_mempool_get(mempool, &sess_private_data)) {
-               QAT_LOG(ERR,
-                       "Couldn't get object from session mempool");
-               return -ENOMEM;
-       }
-
-       session = sess_private_data;
-       if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_MODEX) {
-               if (xform->modex.exponent.length == 0 ||
-                               xform->modex.modulus.length == 0) {
-                       QAT_LOG(ERR, "Invalid mod exp input parameter");
-                       err = -EINVAL;
-                       goto error;
-               }
-       } else if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_MODINV) {
-               if (xform->modinv.modulus.length == 0) {
-                       QAT_LOG(ERR, "Invalid mod inv input parameter");
-                       err = -EINVAL;
-                       goto error;
-               }
-       } else if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_RSA) {
-               if (xform->rsa.n.length == 0) {
-                       QAT_LOG(ERR, "Invalid rsa input parameter");
-                       err = -EINVAL;
-                       goto error;
-               }
-       } else if (xform->xform_type >= RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END
-                       || xform->xform_type <= RTE_CRYPTO_ASYM_XFORM_NONE) {
-               QAT_LOG(ERR, "Invalid asymmetric crypto xform");
-               err = -EINVAL;
-               goto error;
-       } else {
-               QAT_LOG(ERR, "Asymmetric crypto xform not implemented");
-               err = -EINVAL;
-               goto error;
-       }
-
-       session->xform = xform;
-       qat_asym_build_req_tmpl(sess_private_data);
-       set_asym_session_private_data(sess, dev->driver_id,
-               sess_private_data);
-
-       return 0;
-error:
-       rte_mempool_put(mempool, sess_private_data);
-       return err;
-}
-
-unsigned int qat_asym_session_get_private_size(
-               struct rte_cryptodev *dev __rte_unused)
-{
-       return RTE_ALIGN_CEIL(sizeof(struct qat_asym_session), 8);
-}
-
-void
-qat_asym_session_clear(struct rte_cryptodev *dev,
-               struct rte_cryptodev_asym_session *sess)
-{
-       uint8_t index = dev->driver_id;
-       void *sess_priv = get_asym_session_private_data(sess, index);
-       struct qat_asym_session *s = (struct qat_asym_session *)sess_priv;
-
-       if (sess_priv) {
-               memset(s, 0, qat_asym_session_get_private_size(dev));
-               struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv);
-
-               set_asym_session_private_data(sess, index, NULL);
-               rte_mempool_put(sess_mp, sess_priv);
-       }
-}
+static struct cryptodev_driver qat_crypto_drv;
+RTE_PMD_REGISTER_CRYPTO_DRIVER(qat_crypto_drv,
+               cryptodev_qat_asym_driver,
+               qat_asym_driver_id);
diff --git a/drivers/crypto/qat/qat_asym.h b/drivers/crypto/qat/qat_asym.h
index 308b6b2e0b..655a835c7f 100644
--- a/drivers/crypto/qat/qat_asym.h
+++ b/drivers/crypto/qat/qat_asym.h
@@ -8,10 +8,13 @@
 #include <cryptodev_pmd.h>
 #include <rte_crypto_asym.h>
 #include "icp_qat_fw_pke.h"
-#include "qat_common.h"
-#include "qat_asym_pmd.h"
+#include "qat_device.h"
+#include "qat_crypto.h"
 #include "icp_qat_fw.h"
 
+/** Intel(R) QAT Asymmetric Crypto PMD driver name */
+#define CRYPTODEV_NAME_QAT_ASYM_PMD    crypto_qat_asym
+
 typedef uint64_t large_int_ptr;
 #define MAX_PKE_PARAMS 8
 #define QAT_PKE_MAX_LN_SIZE 512
@@ -26,6 +29,32 @@ typedef uint64_t large_int_ptr;
 #define QAT_ASYM_RSA_NUM_OUT_PARAMS            1
 #define QAT_ASYM_RSA_QT_NUM_IN_PARAMS          6
 
+uint8_t qat_asym_driver_id;
+
+struct qat_crypto_gen_dev_ops qat_asym_gen_dev_ops[QAT_N_GENS];
+
+/**
+ * helper function to add an asym capability
+ * <name> <op type> <modlen (min, max, increment)>
+ **/
+#define QAT_ASYM_CAP(n, o, l, r, i)                                    \
+       {                                                               \
+               .op = RTE_CRYPTO_OP_TYPE_ASYMMETRIC,                    \
+               {.asym = {                                              \
+                       .xform_capa = {                                 \
+                               .xform_type = RTE_CRYPTO_ASYM_XFORM_##n,\
+                               .op_types = o,                          \
+                               {                                       \
+                               .modlen = {                             \
+                               .min = l,                               \
+                               .max = r,                               \
+                               .increment = i                          \
+                               }, }                                    \
+                       }                                               \
+               },                                                      \
+               }                                                       \
+       }
+
 struct qat_asym_op_cookie {
        size_t alg_size;
        uint64_t error;
@@ -45,6 +74,27 @@ struct qat_asym_session {
        struct rte_crypto_asym_xform *xform;
 };
 
+static inline void
+qat_fill_req_tmpl(struct icp_qat_fw_pke_request *qat_req)
+{
+       memset(qat_req, 0, sizeof(*qat_req));
+       qat_req->pke_hdr.service_type = ICP_QAT_FW_COMN_REQ_CPM_FW_PKE;
+
+       qat_req->pke_hdr.hdr_flags =
+                       ICP_QAT_FW_COMN_HDR_FLAGS_BUILD
+                       (ICP_QAT_FW_COMN_REQ_FLAG_SET);
+}
+
+static inline void
+qat_asym_build_req_tmpl(void *sess_private_data)
+{
+       struct icp_qat_fw_pke_request *qat_req;
+       struct qat_asym_session *session = sess_private_data;
+
+       qat_req = &session->req_tmpl;
+       qat_fill_req_tmpl(qat_req);
+}
+
 int
 qat_asym_session_configure(struct rte_cryptodev *dev,
                struct rte_crypto_asym_xform *xform,
@@ -76,7 +126,9 @@ qat_asym_session_clear(struct rte_cryptodev *dev,
  */
 int
 qat_asym_build_request(void *in_op, uint8_t *out_msg,
-               void *op_cookie, enum qat_device_gen qat_dev_gen);
+               void *op_cookie,
+               __rte_unused uint64_t *opaque,
+               enum qat_device_gen qat_dev_gen);
 
 /*
  * Process PKE response received from outgoing queue of QAT
@@ -88,8 +140,11 @@ qat_asym_build_request(void *in_op, uint8_t *out_msg,
  * @param      op_cookie       Cookie pointer that holds private metadata
  *
  */
+int
+qat_asym_process_response(void __rte_unused * *op, uint8_t *resp,
+               void *op_cookie, __rte_unused uint64_t *dequeue_err_count);
+
 void
-qat_asym_process_response(void __rte_unused **op, uint8_t *resp,
-               void *op_cookie);
+qat_asym_init_op_cookie(void *cookie);
 
 #endif /* _QAT_ASYM_H_ */
-- 
2.17.1

Reply via email to