> This patch reworks QAT symmetric crypto datapatch implementation where > each > generation request building separated and the crypto operation under the > raw datapath api implementation are unified. > > In addtion this patchset also enables QAT OOP support in raw datapath api > implementation. >
The patches do not apply cleanly. Please rebase into a single series. Rework patch titles as follows [v7,1/9] common/qat: define gen specific structs and functions [v7,2/9] common/qat: add gen specific device implementation [v7,3/9] common/qat: add gen specific queue pair function [v7,4/9] common/qat: add gen specific queue implementation [v7,5/9] compress/qat: define gen specific structs and functions [v7,6/9] compress/qat: add gen specific implementation [v7,7/9] crypto/qat: unify device private data structure [v7,8/9] crypto/qat: define gen specific structs and functions [v7,9/9] crypto/qat: add gen specific implementation [v3,1/8] crypto/qat: refactor driver skeleton [v3,2/8] crypto/qat: refactor symmetric ops [v3,3/8] crypto/qat: refactor asymmetric ops [v3,4/8] crypto/qat: rework session APIs [v3,5/8] crypto/qat: rework data path [v3,6/8] crypto/qat: support out of place SG list [v3,7/8] test/crypto: fix ---- The title and description do not show what is happening and what the patch is fixing. [v3,8/8] crypto/qat: rework ---- Can you think of some better title for this one? Also, the description does not specify On what basis rework is done. > http://patchwork.dpdk.org/project/dpdk/cover/20211027155055.32264-1-kai...@intel.com/ > > v3: > - sperate a single patch 6 to two different patches > > v2: > - review comments addressed > > Kai Ji (8): > crypro/qat: qat driver refactor skeleton > crypto/qat: qat driver sym op refactor > crypto/qat: qat driver asym op refactor > crypto/qat: qat driver session method rework > crypto/qat: qat driver datapath rework > crypto/qat: support sgl oop operation > app/test: cryptodev test fix > crypto/qat: qat driver rework clean up > > app/test/test_cryptodev.c | 58 +- > drivers/common/qat/meson.build | 4 +- > drivers/common/qat/qat_device.c | 2 +- > drivers/common/qat/qat_qp.c | 40 +- > drivers/common/qat/qat_qp.h | 70 +- > drivers/compress/qat/qat_comp_pmd.c | 12 +- > drivers/crypto/qat/dev/qat_asym_pmd_gen1.c | 7 + > drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c | 90 ++ > drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 487 +++++++++ > drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 253 +++++ > drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 911 +++++++++++++++++ > drivers/crypto/qat/dev/qat_sym_pmd_gen1.c | 939 ++++++++++++++++++ > drivers/crypto/qat/qat_asym.c | 786 +++++++++------ > drivers/crypto/qat/qat_asym.h | 77 +- > drivers/crypto/qat/qat_asym_pmd.c | 231 ----- > drivers/crypto/qat/qat_asym_pmd.h | 54 - > drivers/crypto/qat/qat_crypto.c | 1 + > drivers/crypto/qat/qat_crypto.h | 14 +- > drivers/crypto/qat/qat_sym.c | 978 ++++++------------ > drivers/crypto/qat/qat_sym.h | 141 ++- > drivers/crypto/qat/qat_sym_hw_dp.c | 983 ------------------- > drivers/crypto/qat/qat_sym_pmd.c | 251 ----- > drivers/crypto/qat/qat_sym_pmd.h | 95 -- > drivers/crypto/qat/qat_sym_session.c | 114 +-- > drivers/crypto/qat/qat_sym_session.h | 8 +- > 25 files changed, 3861 insertions(+), 2745 deletions(-) > delete mode 100644 drivers/crypto/qat/qat_asym_pmd.c > delete mode 100644 drivers/crypto/qat/qat_asym_pmd.h > delete mode 100644 drivers/crypto/qat/qat_sym_hw_dp.c > delete mode 100644 drivers/crypto/qat/qat_sym_pmd.c > delete mode 100644 drivers/crypto/qat/qat_sym_pmd.h > > -- > 2.17.1