04/11/2021 15:55, Thomas Monjalon:
> last changes to make this series "more acceptable":
> - RTE_SCHED_CMAN in rte_config.h, replacing RTE_SCHED_RED
> - test file listed in MAINTAINERS
> - few whitespaces fixed
Applied this last version.
The maintainers of this library didn't help really.
Review of basic stuff and process well known by maintainers were not done.
Even after doing these last changes myself, this library is still in a poor
state.
The most problematic is the big amount of dead code disabled in
config/rte_config.h:
#undef RTE_SCHED_CMAN
#undef RTE_SCHED_COLLECT_STATS
#undef RTE_SCHED_SUBPORT_TC_OV
#define RTE_SCHED_PORT_N_GRINDERS 8
#undef RTE_SCHED_VECTOR
I think the most appropriate going forward is to stop merging any feature
in the libraries and examples related to sched and pipeline,
until a proper resolution is done for this dead code.
Tips: make runtime options and properly document them.
Note: I probably won't reply to this thread until 21.11 is done,
because I have other priorities and I don't want to hear about this for some
time.
