> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yi...@intel.com>
> Sent: Wednesday, November 3, 2021 10:13 PM
> To: Xu, Ting <ting...@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zh...@intel.com>; Yang, Qiming
> <qiming.y...@intel.com>; Guo, Junfeng <junfeng....@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/ice: enable protocol agnostic flow
> offloading in RSS
>
> On 11/2/2021 1:49 AM, Ting Xu wrote:
> > +static int
> > +ice_hash_rem_raw_cfg(struct ice_adapter *ad,
> > + struct ice_parser_profile *prof,
> > + u16 vsi_handle)
> > +{
> > + struct ice_hw *hw = &ad->hw;
> > + int ptg, ret;
> > + u16 vsig;
> > + u64 id;
> > +
> > + id = (u64)ice_find_first_bit(prof->ptypes, 0xFFFF);
> > +
> > + ptg = hw->blk[ICE_BLK_RSS].xlt1.t[id];
> > +
> > + memset(&ad->rss_prof_info[ptg], 0,
> > + sizeof(struct ice_rss_prof_info));
> > +
> > + /* check if vsig is already removed */
> > + ret = ice_vsig_find_vsi(hw, ICE_BLK_RSS,
> > + ice_get_hw_vsi_num(hw, vsi_handle), &vsig);
> > + if (!ret && vsig) {
> > + ret = ice_rem_prof_id_flow(hw, ICE_BLK_RSS,
> > + ice_get_hw_vsi_num(hw,
> vsi__handle),
>
> The set doesn't compile, 'vsi__handle' is not defined.
>
> Most probably it is a typo for 'vsi_handle', but I was reluctant to fix it in
> next-
> net. If the code sent without compiling, there may be other issues missed, can
> you please check the set again, build it, test it and send a new version?
>
> Thanks,
> Ferruh
Hi, Ferruh, Sorry for the missing check since I was hurried when submitted this
patchset after update.
A new version is sent now with build and test passed. Thanks!
