On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon <tho...@monjalon.net> wrote:
>
> 03/11/2021 12:56, Radu Nicolau:
> > When STATS_INTERVAL is set to a non-zero value the core_statistics array
> > will be defined in multiple compilation units and this can trigger a
> > linker error on particular environments. In order to fix this the
> > core_statistics definition was moved out of the header file.
>
> So it is not fixing compilation,
> as we would never apply a patch which would completely break compilation.
> I would say (in the title) that it moves global variable from header file.
>
> > Fixes: 1329602b6c8f ("examples/ipsec-secgw: add per-core packet statistics")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Radu Nicolau <radu.nico...@intel.com>I guess it has to do with series: https://patchwork.dpdk.org/project/dpdk/list/?series=20174 http://mails.dpdk.org/archives/test-report/2021-November/237332.html So it should be part of this series. -- David Marchand
