26/10/2021 12:20, Liguzinski, WojciechX: > Hi, > > V16 - My bad, probably I haven't copied it correctly when preparing cover > letter > V17 - I understood Cristian's comment as to copy the Series ACK to next > versions of patches, and not to "split it" for each one. If that was the > correct way I had no knowledge about it.
Yes you had to reproduce it in each patch. Otherwise who would do it to make it appear in patchwork and in the git history when merged? I understand you did not have that knowledge. For future, I hope the Intel team will better track features patches of newcomers so they don't miss something knew by others. John, I know knowledge sharing is not an easy task, we always have to improve :) > From: Thomas Monjalon <tho...@monjalon.net> > 26/10/2021 12:02, Dumitrescu, Cristian: > > From: Thomas Monjalon <tho...@monjalon.net> > > > 26/10/2021 10:24, Liu, Yu Y: > > > > Hi Thomas, > > > > > > > > Would you merge this patch as the series is acked by Cristian as below? > > > > > > > https://patchwork.dpdk.org/project/dpdk/cover/20211019081902.3514841 > > > - > > > 1-wojciechx.liguzin...@intel.com/ > > > > > > I didn't see any email from Cristian. > > > It seems you just added this ack silently at the bottom of the cover > > > letter. > > > > > > 1/ an email from Cristian is far better 2/ when integrating ack, it > > > must be done in patches, not cover letter > > > > > > > Hi Thomas, > > > > I did ack this set in a previous version (V15) by replying with > > "Series-acked-by" on the cover letter email, which does not show in > > patchwork. Is there a better way to do this? > > No you did the right thing (I missed this email on v15). > But v16 did not show your ack. > And v17 added it only in the cover letter instead of reporting it in all > patches. > > > > It would be good to have Jasvinder's ack as well on this series, as he is > > looking into some other aspects of the sched library. > > Yes > > >
