> -----邮件原件-----
> 发件人: Jerin Jacob <jerinjac...@gmail.com>
> 发送时间: Wednesday, October 27, 2021 6:58 PM
> 收件人: Feifei Wang <feifei.wa...@arm.com>; Ananyev, Konstantin
> <konstantin.anan...@intel.com>; Stephen Hemminger
> <step...@networkplumber.org>; David Marchand
> <david.march...@redhat.com>; tho...@monjalon.net
> 抄送: dpdk-dev <dev@dpdk.org>; nd <n...@arm.com>
> 主题: Re: [dpdk-dev] [PATCH v6 0/4] add new definitions for wait scheme
>
> On Wed, Oct 27, 2021 at 1:40 PM Feifei Wang <feifei.wa...@arm.com>
> wrote:
> >
> > Add new definitions for wait scheme, and apply this new definitions
> > into lib to replace rte_pause.
> >
> > v2:
> > 1. use macro to create new wait scheme (Stephen)
> >
> > v3:
> > 1. delete unnecessary bug fix in bpf (Konstantin)
> >
> > v4:
> > 1. put size into the macro body (Konstantin) 2. replace assert with
> > BUILD_BUG_ON (Stephen) 3. delete unnecessary compiler barrier for bpf
> > (Konstantin)
> >
> > v5:
> > 1. 'size' is not the parameter (Konstantin) 2. put () around macro
> > parameters (Konstantin) 3. fix some original typo issue (Jerin) 4.
> > swap 'rte_wait_event' parameter location (Jerin) 5. add new macro
> > '__LOAD_EXC'
> > 6. delete 'undef' to prevent compilation warning
>
> + David, Konstantin, Stephen,
>
> Please make a practice to add exiting reviewers.
That's Ok.
>
> undef the local marco may result in conflict with other libraries.
> Please add __RTE_ARM_ for existing macros (mark as internal) to fix the
> namespace if we are taking that path
Thanks for the comments, I will update this in the next version.
>
> >
> > v6:
> > 1. fix patch style check warning
> > 2. delete 'bpf' patch due to 'const' limit
> >
> > Feifei Wang (4):
> > eal: add new definitions for wait scheme
> > eal: use wait event for read pflock
> > eal: use wait event scheme for mcslock
> > lib/distributor: use wait event scheme
> >
> > lib/distributor/rte_distributor_single.c | 10 +-
> > lib/eal/arm/include/rte_pause_64.h | 136 +++++++++++++----------
> > lib/eal/include/generic/rte_mcslock.h | 9 +-
> > lib/eal/include/generic/rte_pause.h | 28 +++++
> > lib/eal/include/generic/rte_pflock.h | 4 +-
> > 5 files changed, 119 insertions(+), 68 deletions(-)
> >
> > --
> > 2.25.1
> >
