Hi Bruce, I observed a large number of checkpatch errors [1] when synchronizing to our inner CI, almost all of them are over 80 lines, and many are not LONG LOG.
The DPDK coding style recommends to be not more than 80 characters unless rarest situations (which LONG LOG belongs to this one I think). I don't know which to follow: just ignore or should fix it ? [1]: lib/dmadev/rte_dmadev.c:56: WARNING:LONG_LINE: line length of 95 exceeds 80 columns lib/dmadev/rte_dmadev.c:696: WARNING:LONG_LINE: line length of 87 exceeds 80 columns lib/dmadev/rte_dmadev.c:704: WARNING:LONG_LINE: line length of 85 exceeds 80 columns lib/dmadev/rte_dmadev.h:267: WARNING:LONG_LINE_COMMENT: line length of 84 exceeds 80 columns lib/dmadev/rte_dmadev.h:269: WARNING:LONG_LINE_COMMENT: line length of 84 exceeds 80 columns lib/dmadev/rte_dmadev.h:677: WARNING:LONG_LINE_COMMENT: line length of 91 exceeds 80 columns lib/dmadev/rte_dmadev.h:683: WARNING:LONG_LINE_COMMENT: line length of 95 exceeds 80 columns lib/dmadev/rte_dmadev.h:691: WARNING:LONG_LINE_COMMENT: line length of 90 exceeds 80 columns lib/dmadev/rte_dmadev.h:692: WARNING:LONG_LINE_COMMENT: line length of 82 exceeds 80 columns lib/dmadev/rte_dmadev.h:706: WARNING:LONG_LINE: line length of 88 exceeds 80 columns lib/dmadev/rte_dmadev_core.h:51: WARNING:LONG_LINE: line length of 86 exceeds 80 columns lib/dmadev/rte_dmadev_pmd.h:58: WARNING:LONG_LINE: line length of 84 exceeds 80 columns total: 1 errors, 12 warnings, 235 lines checked app/test/test_dmadev.c:19: WARNING:LONG_LINE: line length of 95 exceeds 80 columns app/test/test_dmadev.c:19: WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided app/test/test_dmadev.c:39: WARNING:LONG_LINE: line length of 94 exceeds 80 columns app/test/test_dmadev.c:72: WARNING:LONG_LINE_COMMENT: line length of 90 exceeds 80 columns app/test/test_dmadev.c:77: WARNING:LONG_LINE_COMMENT: line length of 96 exceeds 80 columns app/test/test_dmadev.c:79: WARNING:LONG_LINE: line length of 83 exceeds 80 columns app/test/test_dmadev.c:85: WARNING:LONG_LINE_COMMENT: line length of 95 exceeds 80 columns app/test/test_dmadev.c:90: WARNING:LONG_LINE_COMMENT: line length of 90 exceeds 80 columns app/test/test_dmadev.c:113: WARNING:LONG_LINE: line length of 86 exceeds 80 columns app/test/test_dmadev.c:114: WARNING:LONG_LINE: line length of 98 exceeds 80 columns app/test/test_dmadev.c:115: WARNING:LONG_LINE: line length of 81 exceeds 80 columns app/test/test_dmadev.c:124: WARNING:LONG_LINE: line length of 85 exceeds 80 columns app/test/test_dmadev.c:129: WARNING:LONG_LINE: line length of 81 exceeds 80 columns app/test/test_dmadev.c:138: WARNING:LONG_LINE: line length of 96 exceeds 80 columns app/test/test_dmadev.c:143: WARNING:LONG_LINE: line length of 97 exceeds 80 columns app/test/test_dmadev.c:157: WARNING:LONG_LINE: line length of 90 exceeds 80 columns app/test/test_dmadev.c:158: WARNING:LONG_LINE: line length of 88 exceeds 80 columns app/test/test_dmadev.c:169: WARNING:LONG_LINE: line length of 92 exceeds 80 columns app/test/test_dmadev.c:196: WARNING:LONG_LINE: line length of 94 exceeds 80 columns app/test/test_dmadev.c:207: WARNING:LONG_LINE: line length of 95 exceeds 80 columns app/test/test_dmadev.c:249: WARNING:LONG_LINE: line length of 88 exceeds 80 columns app/test/test_dmadev.c:254: WARNING:LONG_LINE: line length of 81 exceeds 80 columns app/test/test_dmadev.c:272: WARNING:LONG_LINE_COMMENT: line length of 99 exceeds 80 columns app/test/test_dmadev.c:277: WARNING:LONG_LINE_COMMENT: line length of 91 exceeds 80 columns app/test/test_dmadev.c:287: WARNING:LONG_LINE: line length of 86 exceeds 80 columns app/test/test_dmadev.c:299: WARNING:LONG_LINE_COMMENT: line length of 86 exceeds 80 columns app/test/test_dmadev.c:302: WARNING:LONG_LINE: line length of 94 exceeds 80 columns app/test/test_dmadev.c:306: WARNING:LONG_LINE: line length of 81 exceeds 80 columns app/test/test_dmadev.c:313: WARNING:LONG_LINE: line length of 94 exceeds 80 columns app/test/test_dmadev.c:314: WARNING:LONG_LINE: line length of 85 exceeds 80 columns app/test/test_dmadev.c:329: WARNING:LONG_LINE_COMMENT: line length of 82 exceeds 80 columns app/test/test_dmadev.c:331: WARNING:LONG_LINE: line length of 86 exceeds 80 columns app/test/test_dmadev.c:332: WARNING:LONG_LINE: line length of 82 exceeds 80 columns app/test/test_dmadev.c:338: WARNING:LONG_LINE_COMMENT: line length of 97 exceeds 80 columns app/test/test_dmadev.c:339: WARNING:LONG_LINE_COMMENT: line length of 96 exceeds 80 columns app/test/test_dmadev.c:344: WARNING:LONG_LINE: line length of 90 exceeds 80 columns app/test/test_dmadev.c:351: WARNING:LONG_LINE_COMMENT: line length of 92 exceeds 80 columns app/test/test_dmadev.c:357: WARNING:LONG_LINE_COMMENT: line length of 85 exceeds 80 columns app/test/test_dmadev.c:367: WARNING:LONG_LINE: line length of 94 exceeds 80 columns app/test/test_dmadev.c:368: WARNING:LONG_LINE: line length of 85 exceeds 80 columns app/test/test_dmadev.c:372: WARNING:LONG_LINE: line length of 93 exceeds 80 columns app/test/test_dmadev.c:379: WARNING:LONG_LINE: line length of 85 exceeds 80 columns app/test/test_dmadev.c:380: WARNING:LONG_LINE: line length of 86 exceeds 80 columns app/test/test_dmadev.c:392: WARNING:LONG_LINE: line length of 94 exceeds 80 columns app/test/test_dmadev.c:396: WARNING:LONG_LINE: line length of 81 exceeds 80 columns app/test/test_dmadev.c:421: WARNING:LONG_LINE_COMMENT: line length of 87 exceeds 80 columns app/test/test_dmadev.c:441: WARNING:LONG_LINE: line length of 86 exceeds 80 columns app/test/test_dmadev.c:443: WARNING:LONG_LINE_COMMENT: line length of 83 exceeds 80 columns app/test/test_dmadev.c:455: WARNING:LONG_LINE: line length of 94 exceeds 80 columns app/test/test_dmadev.c:459: WARNING:LONG_LINE: line length of 81 exceeds 80 columns app/test/test_dmadev.c:479: WARNING:LONG_LINE: line length of 81 exceeds 80 columns app/test/test_dmadev.c:503: WARNING:LONG_LINE: line length of 98 exceeds 80 columns app/test/test_dmadev.c:515: WARNING:LONG_LINE_COMMENT: line length of 92 exceeds 80 columns app/test/test_dmadev.c:524: WARNING:LONG_LINE: line length of 81 exceeds 80 columns app/test/test_dmadev.c:529: WARNING:LONG_LINE: line length of 85 exceeds 80 columns app/test/test_dmadev.c:533: WARNING:LONG_LINE: line length of 93 exceeds 80 columns app/test/test_dmadev.c:548: WARNING:LONG_LINE_COMMENT: line length of 88 exceeds 80 columns app/test/test_dmadev.c:551: WARNING:LONG_LINE_COMMENT: line length of 92 exceeds 80 columns app/test/test_dmadev.c:560: WARNING:LONG_LINE: line length of 81 exceeds 80 columns app/test/test_dmadev.c:568: WARNING:LONG_LINE: line length of 87 exceeds 80 columns app/test/test_dmadev.c:570: WARNING:LONG_LINE: line length of 81 exceeds 80 columns app/test/test_dmadev.c:598: WARNING:LONG_LINE: line length of 94 exceeds 80 columns app/test/test_dmadev.c:601: WARNING:LONG_LINE: line length of 83 exceeds 80 columns app/test/test_dmadev.c:605: WARNING:LONG_LINE_COMMENT: line length of 95 exceeds 80 columns app/test/test_dmadev.c:611: WARNING:LONG_LINE: line length of 83 exceeds 80 columns app/test/test_dmadev.c:624: WARNING:LONG_LINE_COMMENT: line length of 93 exceeds 80 columns app/test/test_dmadev.c:625: WARNING:LONG_LINE_COMMENT: line length of 90 exceeds 80 columns app/test/test_dmadev.c:648: WARNING:LONG_LINE: line length of 91 exceeds 80 columns app/test/test_dmadev.c:654: WARNING:LONG_LINE: line length of 94 exceeds 80 columns app/test/test_dmadev.c:660: WARNING:LONG_LINE: line length of 83 exceeds 80 columns app/test/test_dmadev.c:662: WARNING:LONG_LINE_COMMENT: line length of 85 exceeds 80 columns app/test/test_dmadev.c:693: WARNING:LONG_LINE: line length of 84 exceeds 80 columns app/test/test_dmadev.c:697: WARNING:LONG_LINE: line length of 88 exceeds 80 columns app/test/test_dmadev.c:698: WARNING:LONG_LINE: line length of 84 exceeds 80 columns app/test/test_dmadev.c:702: WARNING:LONG_LINE: line length of 91 exceeds 80 columns app/test/test_dmadev.c:713: WARNING:LONG_LINE: line length of 84 exceeds 80 columns app/test/test_dmadev.c:719: WARNING:LONG_LINE: line length of 90 exceeds 80 columns app/test/test_dmadev.c:721: WARNING:LONG_LINE: line length of 100 exceeds 80 columns app/test/test_dmadev.c:755: WARNING:LONG_LINE: line length of 85 exceeds 80 columns app/test/test_dmadev.c:765: WARNING:LONG_LINE: line length of 93 exceeds 80 columns app/test/test_dmadev.c:774: WARNING:LONG_LINE: line length of 89 exceeds 80 columns app/test/test_dmadev.c:789: WARNING:LONG_LINE_COMMENT: line length of 88 exceeds 80 columns app/test/test_dmadev.c:790: WARNING:LONG_LINE: line length of 85 exceeds 80 columns app/test/test_dmadev.c:794: WARNING:LONG_LINE: line length of 93 exceeds 80 columns app/test/test_dmadev.c:797: WARNING:LONG_LINE_COMMENT: line length of 97 exceeds 80 columns app/test/test_dmadev.c:802: WARNING:LONG_LINE: line length of 99 exceeds 80 columns app/test/test_dmadev.c:811: WARNING:LONG_LINE: line length of 92 exceeds 80 columns app/test/test_dmadev.c:812: WARNING:LONG_LINE: line length of 86 exceeds 80 columns app/test/test_dmadev.c:833: WARNING:LONG_LINE_COMMENT: line length of 98 exceeds 80 columns total: 0 errors, 89 warnings, 861 lines checked On 2021/10/18 17:20, Thomas Monjalon wrote: > 13/10/2021 17:17, Bruce Richardson: >> Bruce Richardson (10): >> dmadev: add channel status check for testing use >> dma/skeleton: add channel status function >> dma/skeleton: add burst capacity function >> dmadev: add device iterator >> app/test: add basic dmadev instance tests >> app/test: add basic dmadev copy tests >> app/test: run test suite on skeleton driver >> app/test: add more comprehensive dmadev copy tests >> dmadev: add flag for error handling support >> app/test: test dmadev instance failure handling >> >> Kevin Laatz (3): >> dmadev: add burst capacity API >> app/test: add dmadev fill tests >> app/test: add dmadev burst capacity API test > > Applied, thanks. > > > > > . >
