On Wed, 2021-10-20 at 10:29 -0700, Ajit Khaparde wrote: > On Wed, Oct 20, 2021 at 12:54 AM Xueming Li <xuemi...@nvidia.com> wrote: > > > > Adds "--rxq-share=X" parameter to enable shared RxQ, share if device > > supports, otherwise fallback to standard RxQ. > > > > Share group number grows per X ports. X defaults to MAX, implies all > > ports join share group 1. Queue ID is mapped equally with shared Rx > > queue ID. > > > > Forwarding engine "shared-rxq" should be used which Rx only and update > > stream statistics correctly. > > > > Signed-off-by: Xueming Li <xuemi...@nvidia.com> > > --- > > app/test-pmd/config.c | 7 ++++++- > > app/test-pmd/parameters.c | 13 +++++++++++++ > > app/test-pmd/testpmd.c | 20 +++++++++++++++++--- > > app/test-pmd/testpmd.h | 2 ++ > > doc/guides/testpmd_app_ug/run_app.rst | 7 +++++++ > > 5 files changed, 45 insertions(+), 4 deletions(-) > > > :::snip:::: > > > + > > extern uint16_t nb_pkt_per_burst; > > extern uint16_t nb_pkt_flowgen_clones; > > extern int nb_flows_flowgen; > > diff --git a/doc/guides/testpmd_app_ug/run_app.rst > > b/doc/guides/testpmd_app_ug/run_app.rst > > index 640eadeff73..ff5908dcd50 100644 > > --- a/doc/guides/testpmd_app_ug/run_app.rst > > +++ b/doc/guides/testpmd_app_ug/run_app.rst > > @@ -389,6 +389,13 @@ The command line options are: > > > > Generate multiple flows in txonly mode. > > > > +* ``--rxq-share=[X]`` > > + > > + Create queues in shared Rx queue mode if device supports. > > + Group number grows per X ports. X defaults to MAX, implies all ports > > + join share group 1. Forwarding engine "shared-rxq" should be used > > + which Rx only and update stream statistics correctly. > Did you mean "with Rx only"? > Something like this? > "shared-rxq" should be used in Rx only mode. > > If you say - "the Forwarding engine should update stream statistics > correctly", > I think that is expected anyway? So there is no need to mention that > in the guide.
I will change like this: "shared-rxq" should be used, other forwarding engines can't resolve source stream correctly, statistics and forwarding target could be wrong. > > > > + > > * ``--eth-link-speed`` > > > > Set a forced link speed to the ethernet port:: > > -- > > 2.33.0 > >
