On Sat, Oct 9, 2021 at 1:20 PM Dmitry Kozlyuk <dmitry.kozl...@gmail.com> wrote:

snip
> > > +Access to physical addresses is provided by a kernel-mode driver, 
> > > virt2phys.
> > > +It is mandatory for allocating physically-contiguous memory which is 
> > > required
> > > +by hardware PMDs.
> >
> > Should we add specific link to virt2phys README in this section as well?
> >
> > https://git.dpdk.org/dpdk-kmods/tree/windows/README.rst
>
> This link is given above and I consider it general information for all
> drivers. However, reading it carefully, I think docs in dpdk-kmods could be
> restructured as well:
> * Keep windows/README.rst unchanged, except for Device Manager steps,
>   which are actually specific to virt2phys.
> * Create windows/virt2phys/README.rst with instructions above.
> * Change windows/netuio/README.rst: remove the bulk of its content, as it
>   repeats generic instructions, keep netuio-specific Device Manager part.
> Then a specific link for virt2phys here would make sense
> and there will be even less duplication in dpdk-kmods.
> If no one objects, I'll do this in v2.

Looks good to me! Thanks
William

Reply via email to