[dpdk-dev] [PATCH v6 12/17] net/i40e/base: fix checksum is used incorrectly

[Robin Zhang]

The variable checksum from i40e_calc_nvm_checksum is used before return
value is checked. Fix this logic.

Fixes: 8db9e2a1b232 ("i40e: base driver")
Fixes: 3ed6c3246f43 ("i40e/base: handle AQ timeout when releasing NVM")
Cc: sta...@dpdk.org

Signed-off-by: Christopher Pau <christopher....@intel.com>
Signed-off-by: Robin Zhang <robinx.zh...@intel.com>
---
 drivers/net/i40e/base/i40e_nvm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c
index 67e58cc195..f385042601 100644
--- a/drivers/net/i40e/base/i40e_nvm.c
+++ b/drivers/net/i40e/base/i40e_nvm.c
@@ -755,10 +755,11 @@ enum i40e_status_code i40e_update_nvm_checksum(struct 
i40e_hw *hw)
        DEBUGFUNC("i40e_update_nvm_checksum");
 
        ret_code = i40e_calc_nvm_checksum(hw, &checksum);
-       le_sum = CPU_TO_LE16(checksum);
-       if (ret_code == I40E_SUCCESS)
+       if (ret_code == I40E_SUCCESS) {
+               le_sum = CPU_TO_LE16(checksum);
                ret_code = i40e_write_nvm_aq(hw, 0x00, I40E_SR_SW_CHECKSUM_WORD,
                                             1, &le_sum, true);
+       }
 
        return ret_code;
 }
-- 
2.25.1