On 9/22/2021 9:21 PM, Ajit Khaparde wrote: > On Wed, Sep 22, 2021 at 10:36 AM Ferruh Yigit <ferruh.yi...@intel.com> wrote: >> >> On 9/21/2021 5:50 AM, Ajit Khaparde wrote: >>> On Mon, Sep 20, 2021 at 12:42 AM Venkat Duvvuru >>> <venkatkumar.duvv...@broadcom.com> wrote: >>>> >>>> This patch set adds support for new offload features/enhancments for >>>> Thor adapters like VF representor support, new flow matches/actions >>>> & dynamic SRAM manager support. >>>> >>>> Farah Smith (4): >>>> net/bnxt: updates to TF core index table >>>> net/bnxt: add SRAM manager model >>>> net/bnxt: change log level to debug >>>> net/bnxt: add SRAM manager shared session >>>> >>>> Jay Ding (1): >>>> net/bnxt: add flow meter drop counter support >>>> >>>> Kishore Padmanabha (6): >>>> net/bnxt: add flow template support for Thor >>>> net/bnxt: add support for tunnel offload API >>>> net/bnxt: add support for dynamic encap action >>>> net/bnxt: add wild card TCAM byte order for Thor >>>> net/bnxt: add flow templates for Thor >>>> net/bnxt: add enhancements to TF ULP >>>> >>>> Peter Spreadborough (1): >>>> net/bnxt: enable dpool allocator >>>> >>>> Randy Schacher (1): >>>> net/bnxt: dynamically allocate space for EM defrag function >>> >>> For the patchset, >>> Acked-by: Ajit Khaparde <ajit.khapa...@broadcom.com> >>> >>> Patchset applied to dpdk-next-net-brcm. >>> 1) Changed instance of TF to TRUFLOW during merge in patch 1/13 and 13/13. >>> >>> Please apply to dpdk-next-net. Thanks >>> >> >> Hi Ajit, >> >> The github actions fails on build for gcc, please check it on my personal >> github >> repo: >> https://github.com/ferruhy/dpdk/actions/runs/1262767538 >> >> I don't have this error in my environment, this can be related to the >> slightly >> older compiler in the github (gcc 7.5) > > Yes, even I did not see this. Looks genuine and likely because of some > different compiler. > I will try to submit a fix. Will you be able to squash it with the > relevant commit? >
If you can send the fix on top of latest next-net, I can squash it in next-net, assuming the fix is simple. > > > FAILED: drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.c.o > ccache gcc -Idrivers/a715181@@tmp_rte_net_bnxt@sta -Idrivers > -I../drivers -Idrivers/net/bnxt -I../drivers/net/bnxt > -Idrivers/net/bnxt/tf_ulp -I../drivers/net/bnxt/tf_ulp > -Idrivers/net/bnxt/tf_ulp/generic_templates > -I../drivers/net/bnxt/tf_ulp/generic_templates > -Idrivers/net/bnxt/tf_core -I../drivers/net/bnxt/tf_core > -Idrivers/net/bnxt/hcapi/cfa -I../drivers/net/bnxt/hcapi/cfa > -Ilib/ethdev -I../lib/ethdev -I. -I../ -Iconfig -I../config > -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include > -I../lib/eal/linux/include -Ilib/eal/x86/include > -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common > -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs > -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics > -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf > -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring > -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci > -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev > -I../drivers/bus/vdev -fdiagnostics-color=always -pipe > -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O2 -g -include > rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat > -Wformat-nonliteral -Wformat-security -Wmissing-declarations > -Wmissing-prototypes -Wnested-externs -Wold-style-definition > -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef > -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC > -march=corei7 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API > -Wno-format-truncation -DRTE_LIBRTE_BNXT_TF -DSUPPORT_CFA_HW_ALL=1 > -DCC_AVX2_SUPPORT -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.bnxt -MD -MQ > 'drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.c.o' > -MF 'drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.c.o.d' > -o 'drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.c.o' > -c ../drivers/net/bnxt/tf_core/tf_sram_mgr.c > ../drivers/net/bnxt/tf_core/tf_sram_mgr.c: In function ‘tf_sram_mgr_bind’: > ../drivers/net/bnxt/tf_core/tf_sram_mgr.c:418:19: error: ‘slice_list’ > may be used uninitialized in this function > [-Werror=maybe-uninitialized] > slice_list->tail = NULL; > ^ > ../drivers/net/bnxt/tf_core/tf_sram_mgr.c:574:29: note: ‘slice_list’ > was declared here > struct tf_sram_slice_list *slice_list; > ^~~~~~~~~~ > cc1: all warnings being treated as errors > >> >> Can you please check the build error? I will keep the set in next-net for >> now, >> but won't mark it to pull to main until issue is resolved. >> If the fix is trivial, we can update it in the next-net (after issue >> recorded in >> mail list), if it is not trivial may require a new version of the set. >> >> >> btw, in git history 'TruFlow' is used, so I continue to use it, fyi. > No problem. Thanks > >> >> Thanks, >> ferruh >>
