> -----Original Message----- > From: wangyunjian <wangyunj...@huawei.com> > Sent: Saturday, September 18, 2021 11:11 > To: Wang, Haiyue <haiyue.w...@intel.com>; dev@dpdk.org > Cc: Xing, Beilei <beilei.x...@intel.com>; Yang, Qiming > <qiming.y...@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com>; dingxiaoxiong <dingxiaoxi...@huawei.com> > Subject: RE: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when releasing > queues > > > -----Original Message----- > > From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > > Sent: Friday, September 17, 2021 11:47 PM > > To: wangyunjian <wangyunj...@huawei.com>; dev@dpdk.org > > Cc: Xing, Beilei <beilei.x...@intel.com>; Yang, Qiming > > <qiming.y...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; dingxiaoxiong > > <dingxiaoxi...@huawei.com> > > Subject: RE: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when > > releasing > > queues > > > > > -----Original Message----- > > > From: Yunjian Wang <wangyunj...@huawei.com> > > > Sent: Friday, September 17, 2021 19:25 > > > To: dev@dpdk.org > > > Cc: Wang, Haiyue <haiyue.w...@intel.com>; Xing, Beilei > > > <beilei.x...@intel.com>; Yang, Qiming <qiming.y...@intel.com>; Zhang, > > > Qi Z <qi.z.zh...@intel.com>; dingxiaoxi...@huawei.com; Yunjian Wang > > > <wangyunj...@huawei.com> > > > Subject: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when > > > releasing queues > > > > > > Normally when closing the device the queue memzone should be freed. > > > But the memzone will be not freed, when device setup ops like: > > > - rte_eth_bond_slave_remove > > > - rte_eth_dev_internal_reset > > > - eth_dev_rx_queue_config > > > - dev_rx_queue_release > > > - dev_close > > > - dev_free_queues > > > > > > > What's these ops ? function call flow ? And where these names from ? > > The above is simplified, and the original is: > rte_eth_bond_slave_remove > -->__eth_bond_slave_remove_lock_free > ---->slave_remove > ------> rte_eth_dev_internal_reset > --------> rte_eth_dev_rx_queue_config > ----------> eth_dev_rx_queue_config > ------------>i40e_dev_rx_queue_release > rte_eth_dev_close > -->i40e_dev_close > ---->i40e_dev_free_queues > ------>i40e_dev_rx_queue_release(not been called due to nb_rx_queues and > nb_tx_queues are 0) >
Yeah, this is better. The patch LGTM, and make sense. Please update it as new commit message. Thanks! > > > > > In order to free the memzone, we can release the memzone > > > when releasing queues. > > > > > > Signed-off-by: Yunjian Wang <wangyunj...@huawei.com> > > > --- > > > > > > > -- > > > 2.23.0
