On 15/9/2021 11:49 AM, Power, Ciara wrote:
Hi Dave,
-----Original Message-----
From: Richardson, Bruce <bruce.richard...@intel.com>
Sent: Monday 13 September 2021 11:54
To: Hunt, David <david.h...@intel.com>
Cc: dev@dpdk.org; Power, Ciara <ciara.po...@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] usertools/telemetry: add non-interactive
mode
On Mon, Sep 13, 2021 at 11:43:25AM +0100, Bruce Richardson wrote:
On Thu, Sep 09, 2021 at 04:56:25PM +0100, David Hunt wrote:
Add non-interactive mode to dpdk-telemetry.py so that a query string
can be supplied on the command line, and script dumps out data and
exits. Handing for calling from scripts.
Signed-off-by: David Hunt <david.h...@intel.com>
---
Hi Dave,
I'm not sure I like the use of "-q" for adding a query mode - it's
more a shortcut parameter for a "quiet" mode. If I may, I'd suggest an
alternative approach here might be to improve support for piping the
input commands to the script instead so that you can do e.g.
"echo /ethdev/stats,0 | dpdk-telemetry.py"
and have that work well in a script.
I'll do up a patchset for improving that and upstream it for feedback.
Now at: http://patches.dpdk.org/project/dpdk/list/?series=18867
/Bruce
Thanks for this, although I do think the improvement to allow for piping is a
better solution.
I have acked Bruce's patchset, hopefully that will be suitable for your use
case.
Thanks,
Ciara
+1
I'll mark my patchset as superceeded.
Rgds,
Dave.
