On Fri, Sep 03, 2021 at 04:13:41PM +0100, Kevin Laatz wrote: > On 02/09/2021 14:13, Chengwen Feng wrote: > > +++ b/lib/dmadev/rte_dmadev.c > > @@ -0,0 +1,614 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2021 HiSilicon Limited. > > + * Copyright(c) 2021 Intel Corporation. > > + */ > > + > > +#include <ctype.h> > > +#include <inttypes.h> > > +#include <stdint.h> > > +#include <stdio.h> > > +#include <stdlib.h> > > +#include <string.h> > > + > > +#include <rte_debug.h> > > +#include <rte_dev.h> > > +#include <rte_eal.h> > > +#include <rte_errno.h> > > +#include <rte_lcore.h> > > +#include <rte_log.h> > > +#include <rte_memory.h> > > +#include <rte_memzone.h> > > +#include <rte_malloc.h> > > +#include <rte_string_fns.h> > > + > > +#include "rte_dmadev.h" > > +#include "rte_dmadev_pmd.h" > > + > > Many of these includes can be removed from this file, as they are already > included elsewhere (eg. rte_common.h via rte_dmadev.h). > > For example, you could remove: ctype.h, stdint.h, stdlib.h, rte_errno.h, > rte_lcore.h, rte_memory.h, rte_malloc.h, rte_dev... > > Please run test-meson-builds.sh after removing to make sure there are no > missing dependencies. > > <snip> > Actually, first the rte_dmadev.h header should probably have excess headers stripped. Doing quick compilation testing, I still get ok builds from the patchset with "rte_common.h", "rte_dev.h", "rte_errno.h" and "rte_memory.h" removed. On the other hand, for completeness, I believe "stdint.h" should be added for the "uint*_t" types, leaving the top-of-file header includes as:
#include <stdint.h> /* for uint* types */ #include <rte_compat.h> /* for __rte_experimental */ Note: this is not from comprehensive tests just quick builds and looking at the code. Regards, /Bruce
