> > > The crypto mlx5 driver supports multi segment encryption and > > > decryption operations. > > > > > > Added mlx5 multi segment encryption function and multi segment > > > decryption function that will both use the mlx5 vectors. > > > > > > The added tests will test both data integrity and correct stat values. > > > > > > Signed-off-by: Shiri Kuzin <shi...@nvidia.com> > > > Acked-by: Matan Azrad <ma...@nvidia.com> > > > --- > > > app/test/test_cryptodev.c | 277 ++++++++++++++++++++ > > > app/test/test_cryptodev_mlx5_test_vectors.h | 3 - > > > 2 files changed, 277 insertions(+), 3 deletions(-) > > > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > > index 8dbe324b81..4d27a9444c 100644 > > > --- a/app/test/test_cryptodev.c > > > +++ b/app/test/test_cryptodev.c > > > @@ -6681,6 +6681,219 @@ test_mlx5_decryption(const struct > > > mlx5_test_data *tdata) > > > return 0; > > > } > > > > > > +static int > > > +test_mlx5_encryption_sgl(const struct mlx5_test_data *tdata) > > > > The test cases cannot be specific to one particular device. > > Hence the name test_mlx5_xxxx cannot be accepted. > > > > Moreover is it not possible to add aes-xts in test_blockcipher_one_case() > > and add only the test vectors of aes-xts? > > And probably, you do not need a new file for test vectors, XTS is variant of > > AES, Hence the vectors can be part of "test_cryptodev_aes_test_vectors.h". > > > > I don't think there is need for a separate function for XTS right now. > > The current function test_blockcipher_one_case() covers all capability > checks > > And feature flag checks so that the test is skipped for the devices which do > > not Support a specific case. > > > Hi Akhil, > Thank you for taking the time to review this. > I would like to change the test according to your comments as follows: > Use the existing AES-XTS testing function. > Since we require using data-unit and wrapped key I will add two new fields to > the blockcipher_test_data struct: > XTS data unit- to be used by drivers that support data unit. > Wrapped key - to state whether the key is wrapped or not. > I will add vectors which will include the needed data unit and wrapped key to > the "test_cryptodev_aes_test_vectors.h", which will be generic and could be > used by other PMDs as well. > Will that solution align with your comments? I believe this also addresses the > comments you mentioned it the other email. > Please let me know what you think. > Yes this looks good.
You should have 2 separate patches 1. for adding mlx5 crypto PMD in test app. This should be minimal similar to cnxk PMDs. 2. adding aes-xts algo support in test app. I believe SGL is already supported in block cipher, you wont need that one separately.
