06/07/2021 10:47, Akhil Goyal:
> > +static int
> > +mlx5_testsuite_setup(void)
> 
> Please see how other drivers are enabled in this test app.
> We no longer allow PMD specific testsuite.
> Please see the cn9k/cn10k PMD which recently got merged.
> static int
> test_cryptodev_cn9k(void)
> {
>         return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_CN9K_PMD));
> }
> 
> The cases which are not supported by mlx5 crypto PMD will get automatically 
> skipped
> If all capabilities and feature flags are set properly.
> 
> The cases should be generic enough to be used by other PMDs as well.
> @Thomas Monjalon: This patchset is adding PMD specific test cases again
> which we removed in past 3-4 releases.

Good catch Akhil. Indeed tests should be generic.


Reply via email to