On 2021/7/6 14:50, Matan Azrad wrote: > Hi > > From: fengchengwen >> On 2021/7/4 23:21, Matan Azrad wrote: >>> >>> >>> From: Chengwen Feng >>>> This patch introduces 'dmadevice' which is a generic type of DMA >>>> device. >>>> >>>> The APIs of dmadev library exposes some generic operations which can >>>> enable configuration and I/O with the DMA devices. >>>> >>> Did you consider RTE_COMP_ALGO_NULL xform in compressdev library? >>> >> >> em, I just looked at the code. >> >> The RTE_COMP_ALGO_NULL is a small feature of the compression device. >> and currently only mlx5 and isal support it. > > Yes, but what that is mean? > If more drivers support DMA operations they can add the support there, no? >
You mean to expand directly on compressdev ? I think it hard to expand, and may break the compressdev concept. > >> Also the compressdev dataplane API relatively complicated to do just DMA >> copy. > > You snipped more comments I wrote below 😊 > Maybe it is related.... Sorry, I just skipped. 'Did you consider also mbuf API usage for memory descriptor?' ---One scenario of the DMA is vhost-net, which src or dst could be mbuf, but the peer were not mbuf. so here we use raw fields. > >> So I think we need a separate driver framework for the DMA device. > > Need to consider deprecation in compressdev if so.... > >> thanks >> >> [snip] >> >>> >>> >>> . >>> >
