> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Monday, July 5, 2021 4:52 PM > To: Ruifeng Wang <ruifeng.w...@arm.com> > Cc: Bruce Richardson <bruce.richard...@intel.com>; Honnappa Nagarahalli > <honnappa.nagaraha...@arm.com>; tho...@monjalon.net; dev > <dev@dpdk.org>; jer...@marvell.com; nd <n...@arm.com> > Subject: Re: Use WFE for spinlock and ring > > On Fri, May 7, 2021 at 12:24 PM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > > > The problem is inconsistency in performance on different Arm > platforms. > > > > We had decided that each platform needs to enable it after some > testing. > > > > > > > > Then it sounds like it does indeed need to be a build option. Does > > > > it need to be added to the meson_options.txt, or can it just be > > > > specified in cross-files and optionally via c_args? > > > > > > Add it to the meson_options.txt is good as the option will be clearly > exposed. > > > My concern is more options (e.g. RTE_ARCH_ARM64_MEMCPY) need to > be added in. > > > Will the options bloat meson_options.txt? > > > > That bloat would indeed become a concern. We may need to look at more > > use of auto-detection and cross files for such options. > > Ruifeng, > > This series is blocked on this last topic. > Do you intend to send a n+1? I think the best way to expose this config is adding it to meson_options. Will send v4 to update.
> > > -- > David Marchand
