<snip>
> > > > > > 18/06/2021 01:26, Honnappa Nagarahalli: > > > > > On Tue, Jun 15, 2021 at 09:54:51PM -0500, Joyce Kong wrote: > > > > > > Since C11 memory model is adopted in DPDK now[1], use GCC's > > > > > > atomic builtins in test cases. > > > > > > > > > > as previously discussed these atomics are not "C11" they are > > > > > direct use of gcc builtins. please don't incorporate C11 into > > > > > the title of the patches or commit messages since it isn't. > > > > > > > > GCC supports 2 types of built-in atomics, __atomic_xxx[1] and > > > > __sync_xxx [2]. > > > > We need a way to distinguish between them. > > > > We are using "C11" as [1] says they match C++11 memory model. > > > > > > I agree it would be more correct to mention "compiler builtin" > > > as it is not strictly the C11 API. > > The log already mentions "GCC's C11 atomic builtins". I think that is > > correct > enough and represents the change correctly. > > it's misleading and does not attract the correct reviewers particularly due to > prominence in the commit/mail subject. > > please change it to "Use GCC atomic builtins" which describes clearly the > actual change without ambiguity. using "C11" implies the patch is adding > code that uses C11 stdatomic.h and it doesn't. As I mentioned earlier in this thread, GCC supports 2 types of atomics. "Use GCC atomic builtins" does not help distinguish between them. In "GCC's C11 atomic builtins" - "C11" indicates which atomics we are using, "atomic builtins" indicates that we are NOT using APIs from stdatomic.h
